makary/bookmarkfs
1
0
Fork 0
mirror of https://git.sr.ht/~cismonx/bookmarkfs synced 2025-06-07 19:58:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

backend: fix xattr bookmark title check

Browse source 
Do not check if the bookmark title is a valid filename,
as we said in the user manual.

However, we should ensure that the string does not contain
NUL characters, since we assume that a valid bookmark storage
should not contain bookmarks with such names.
This commit is contained in:
CismonX 2025-01-26 19:35:03 +08:00
parent 996ca0e042
commit 3ed11f53e5
No known key found for this signature in database
GPG key ID: 3094873E29A482FB
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
doc/bookmarkfs.texi
View file

@ -1210,8 +1210,8 @@ Extended attributes:
The bookmark title. The bookmark title.
Only available with @option{filename=guid}. Only available with @option{filename=guid}.
This value is allowed be set to any string that is valid UTF-8, This value is allowed be set to any string that does not contain a
and does not have to be valid as a filename. NUL character, and does not have to be valid as a filename.
@item guid @item guid
The bookmark GUID. The bookmark GUID.
@ -1343,8 +1343,8 @@ Extended attributes:
The bookmark title. The bookmark title.
Only available with @option{filename=guid}. Only available with @option{filename=guid}.
This value is allowed be set to any string that is valid UTF-8, This value is allowed be set to any UTF-8 string that does not contain a
and does not have to be valid as a filename. NUL character, and does not have to be valid as a filename.
@item guid @item guid
The bookmark GUID. The bookmark GUID.

2
src/backend_chromium.c
View file

@ -2663,7 +2663,7 @@ bookmark_set (
break; break;
case ATTR_KEY_TITLE: case ATTR_KEY_TITLE:
if (0 != validate_filename(val, val_len, NULL)) { if (NULL != memchr(val, '\0', val_len)) {
return -EINVAL; return -EINVAL;
} }
nocheck = false; nocheck = false;

2
src/backend_firefox.c
View file

@ -3650,7 +3650,7 @@ bookmark_set (
break; break;
case ATTR_KEY_TITLE: case ATTR_KEY_TITLE:
if (0 != validate_filename(val, val_len, NULL)) { if (NULL != memchr(val, '\0', val_len)) {
return -EINVAL; return -EINVAL;
} }
bm_cols.title = val; bm_cols.title = val;