From 88e38bd38e2a4687232568398435fc65aa333834 Mon Sep 17 00:00:00 2001
From: CismonX <admin@cismon.net>
Date: Sat, 1 Feb 2025 00:21:02 +0800
Subject: [PATCH] backend: update cookie even on callback failure

No need to check status and always update cookie after
invoking callback for bookmark_list() and bookmark_fsck().
---
 src/backend_chromium.c |  8 +-------
 src/backend_firefox.c  | 12 ------------
 2 files changed, 1 insertion(+), 19 deletions(-)

diff --git a/src/backend_chromium.c b/src/backend_chromium.c
index 745c595..7481b54 100644
--- a/src/backend_chromium.c
+++ b/src/backend_chromium.c
@@ -1906,9 +1906,6 @@ bookmark_fsck (
         status = fsck_apply(ctx, id, fsck_data, callback, user_data);
 #endif
     }
-    if (status < 0) {
-        return status;
-    }
 
   end:
     if (cookie_ptr != NULL) {
@@ -2053,10 +2050,7 @@ bookmark_list (
             continue;
         }
         status = callback(user_data, &buf);
-        if (status < 0) {
-            return status;
-        }
-        if (status > 0) {
+        if (status != 0) {
             break;
         }
     }
diff --git a/src/backend_firefox.c b/src/backend_firefox.c
index fec83c0..e4e5e8f 100644
--- a/src/backend_firefox.c
+++ b/src/backend_firefox.c
@@ -3056,12 +3056,6 @@ bookmark_fsck (
         status = fsck_apply(ctx, id, fsck_data, &qctx);
 #endif
     }
-    if (status < 0) {
-        if (dentry_map == NULL) {
-            free_dentmap(qctx.dentry_map);
-        }
-        return status;
-    }
     dentry_map = qctx.dentry_map;
     idx        = qctx.next;
 
@@ -3165,12 +3159,6 @@ bookmark_list (
     qctx.callback.list = callback;
     qctx.user_data     = user_data;
     status = bookmark_do_list(ctx, id, off, flags, &qctx);
-    if (status < 0) {
-        if (dentry_map == NULL) {
-            free_dentmap(qctx.dentry_map);
-        }
-        return status;
-    }
     dentry_map = qctx.dentry_map;
 
   end: