From d446030a9ba7a57d91db4d3166d6c76a9ee94d3f Mon Sep 17 00:00:00 2001 From: Ruben Calvo Date: Tue, 3 Jan 2023 01:46:56 +0100 Subject: [PATCH] [ticket/17074] Don't allow to create two roles with the same name PHPBB3-17074 --- phpBB/includes/acp/acp_permission_roles.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpBB/includes/acp/acp_permission_roles.php b/phpBB/includes/acp/acp_permission_roles.php index 80cad9915d..1e092192fa 100644 --- a/phpBB/includes/acp/acp_permission_roles.php +++ b/phpBB/includes/acp/acp_permission_roles.php @@ -179,7 +179,7 @@ class acp_permission_roles $db->sql_freeresult($result); // Make sure we only print out the error if we add the role or change it's name - if ($row && ($mode == 'add' || ($mode == 'edit' && $role_row['role_name'] != $role_name))) + if ($row && ($action == 'add' || ($action == 'edit' && $role_row['role_name'] != $role_name))) { trigger_error(sprintf($user->lang['ROLE_NAME_ALREADY_EXIST'], $role_name) . adm_back_link($this->u_action), E_USER_WARNING); }