makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/12658] Refactoring code

Browse source 
PHPBB3-12658
This commit is contained in:
LEZY Thomas 2014-06-10 09:00:39 +02:00 • committed by Tristan Darricau
parent ab6c9775d3
commit 059f21a3ac
1 changed files with 15 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
tests/console/config/config_test.php
View file

@ -18,21 +18,17 @@ class phpbb_console_command_config_test extends phpbb_test_case
{ {
protected $config; protected $config;
protected $command_name; protected $command_name;
protected $class_name;
protected $command_namespace;
public function setUp() public function setUp()
{ {
$this->config = new \phpbb\config\config(array()); $this->config = new \phpbb\config\config(array());
$this->command_namespace = '\phpbb\console\command\config';
} }
public function test_set_dynamic() public function test_set_dynamic()
{ {
$this->assertEmpty($this->config); $this->assertEmpty($this->config);
$this->class_name = 'set'; $command_tester = $this->get_command_tester('set');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'test_key', 'key' => 'test_key',
@ -47,8 +43,7 @@ class phpbb_console_command_config_test extends phpbb_test_case
{ {
$this->assertEmpty($this->config); $this->assertEmpty($this->config);
$this->class_name = 'set'; $command_tester = $this->get_command_tester('set');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'test_key', 'key' => 'test_key',
@ -66,8 +61,7 @@ class phpbb_console_command_config_test extends phpbb_test_case
$this->config->set('test_key', 'old_value', true); $this->config->set('test_key', 'old_value', true);
$this->assertSame($this->config['test_key'], 'old_value'); $this->assertSame($this->config['test_key'], 'old_value');
$this->class_name = 'set_atomic'; $command_tester = $this->get_command_tester('set_atomic');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'test_key', 'key' => 'test_key',
@ -86,8 +80,7 @@ class phpbb_console_command_config_test extends phpbb_test_case
$this->config->set('test_key', 'old_value', false); $this->config->set('test_key', 'old_value', false);
$this->assertSame($this->config['test_key'], 'old_value'); $this->assertSame($this->config['test_key'], 'old_value');
$this->class_name = 'set_atomic'; $command_tester = $this->get_command_tester('set_atomic');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'test_key', 'key' => 'test_key',
@ -106,8 +99,7 @@ class phpbb_console_command_config_test extends phpbb_test_case
$this->config->set('test_key', 'wrong_value', true); $this->config->set('test_key', 'wrong_value', true);
$this->assertSame($this->config['test_key'], 'wrong_value'); $this->assertSame($this->config['test_key'], 'wrong_value');
$this->class_name = 'set_atomic'; $command_tester = $this->get_command_tester('set_atomic');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'test_key', 'key' => 'test_key',
@ -124,8 +116,7 @@ class phpbb_console_command_config_test extends phpbb_test_case
$this->config->set('test_key', 'test_value', false); $this->config->set('test_key', 'test_value', false);
$this->assertSame($this->config['test_key'], 'test_value'); $this->assertSame($this->config['test_key'], 'test_value');
$this->class_name = 'get'; $command_tester = $this->get_command_tester('get');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'test_key', 'key' => 'test_key',
@ -140,8 +131,7 @@ class phpbb_console_command_config_test extends phpbb_test_case
$this->config->set('test_key', 'test_value', false); $this->config->set('test_key', 'test_value', false);
$this->assertSame($this->config['test_key'], 'test_value'); $this->assertSame($this->config['test_key'], 'test_value');
$this->class_name = 'get'; $command_tester = $this->get_command_tester('get');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'test_key', 'key' => 'test_key',
@ -156,8 +146,7 @@ class phpbb_console_command_config_test extends phpbb_test_case
$this->config->set('test_key', 'test_value', false); $this->config->set('test_key', 'test_value', false);
$this->assertSame($this->config['test_key'], 'test_value'); $this->assertSame($this->config['test_key'], 'test_value');
$this->class_name = 'get'; $command_tester = $this->get_command_tester('get');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'wrong_key', 'key' => 'wrong_key',
@ -172,8 +161,7 @@ class phpbb_console_command_config_test extends phpbb_test_case
$this->config->set('test_key', 0, false); $this->config->set('test_key', 0, false);
$this->assertSame($this->config['test_key'], 0); $this->assertSame($this->config['test_key'], 0);
$this->class_name = 'increment'; $command_tester = $this->get_command_tester('increment');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'test_key', 'key' => 'test_key',
@ -190,8 +178,7 @@ class phpbb_console_command_config_test extends phpbb_test_case
$this->config->set('test_key', 0, false); $this->config->set('test_key', 0, false);
$this->assertSame($this->config['test_key'], 0); $this->assertSame($this->config['test_key'], 0);
$this->class_name = 'increment'; $command_tester = $this->get_command_tester('increment');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'test_key', 'key' => 'test_key',
@ -207,8 +194,7 @@ class phpbb_console_command_config_test extends phpbb_test_case
{ {
$this->assertEmpty($this->config); $this->assertEmpty($this->config);
$this->class_name = 'increment'; $command_tester = $this->get_command_tester('increment');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'test_key', 'key' => 'test_key',
@ -225,9 +211,7 @@ class phpbb_console_command_config_test extends phpbb_test_case
$this->config->set('test_key', 'test_value', false); $this->config->set('test_key', 'test_value', false);
$this->assertSame($this->config['test_key'], 'test_value'); $this->assertSame($this->config['test_key'], 'test_value');
$this->class_name = 'delete'; $command_tester = $this->get_command_tester('delete');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'test_key', 'key' => 'test_key',
@ -241,9 +225,7 @@ class phpbb_console_command_config_test extends phpbb_test_case
{ {
$this->assertEmpty($this->config); $this->assertEmpty($this->config);
$this->class_name = 'delete'; $command_tester = $this->get_command_tester('delete');
$command_tester = $this->get_command_tester();
$command_tester->execute(array( $command_tester->execute(array(
'command' => $this->command_name, 'command' => $this->command_name,
'key' => 'wrong_key', 'key' => 'wrong_key',
@ -253,9 +235,9 @@ class phpbb_console_command_config_test extends phpbb_test_case
$this->assertEmpty($this->config); $this->assertEmpty($this->config);
} }
public function get_command_tester() public function get_command_tester($class_name)
{ {
$command_complete_name = $this->command_namespace . '\\' . $this->class_name; $command_complete_name = '\phpbb\console\command\config' . '\\' . $class_name;
$application = new Application(); $application = new Application();
$application->add(new $command_complete_name($this->config)); $application->add(new $command_complete_name($this->config));
$command = $application->find('config:' . $this->command_name); $command = $application->find('config:' . $this->command_name);