Ignore duplicate IP's for guest counts ... keep in mind this swings 100% the other way from keeping them all, you'll not count some users.

git-svn-id: file:///svn/phpbb/trunk@2236 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Paul S. Owen 2002-03-01 16:39:56 +00:00
parent a54b016790
commit 08fc672b8b

View file

@ -93,12 +93,12 @@ $is_auth_ary = auth(AUTH_VIEW, AUTH_LIST_ALL, $userdata);
// //
// Get user list // Get user list
// //
$sql = "SELECT u.user_id, u.username, u.user_session_time, u.user_session_page, u.user_allow_viewonline, u.user_level, s.session_logged_in, s.session_time, s.session_page $sql = "SELECT u.user_id, u.username, u.user_session_time, u.user_session_page, u.user_allow_viewonline, u.user_level, s.session_logged_in, s.session_time, s.session_page, s.session_ip
FROM " . USERS_TABLE . " u, " . SESSIONS_TABLE . " s FROM " . USERS_TABLE . " u, " . SESSIONS_TABLE . " s
WHERE u.user_id = s.session_user_id WHERE u.user_id = s.session_user_id
AND ( u.user_session_time >= " . ( time() - 300 ) . " AND ( u.user_session_time >= " . ( time() - 300 ) . "
OR s.session_time >= " . ( time() - 300 ) . " ) OR s.session_time >= " . ( time() - 300 ) . " )
ORDER BY u.username ASC, u.user_session_time DESC, s.session_time DESC"; ORDER BY u.username ASC, s.session_ip";
if ( !($result = $db->sql_query($sql)) ) if ( !($result = $db->sql_query($sql)) )
{ {
message_die(GENERAL_ERROR, "Couldn't obtain regd user/online information.", "", __LINE__, __FILE__, $sql); message_die(GENERAL_ERROR, "Couldn't obtain regd user/online information.", "", __LINE__, __FILE__, $sql);
@ -113,6 +113,7 @@ if( $row = $db->sql_fetchrow($result) )
$reg_counter = 0; $reg_counter = 0;
$guest_counter = 0; $guest_counter = 0;
$prev_user = 0; $prev_user = 0;
$prev_ip = 0;
do do
{ {
@ -159,15 +160,20 @@ if( $row = $db->sql_fetchrow($result) )
} }
else else
{ {
$view_online = 1; if ( $row['session_ip'] != $prev_ip )
$guest_users++; {
$view_online = 1;
$username = $lang['Guest']; $guest_users++;
$last_update = $row['session_time'];
$user_page = $row['session_page']; $username = $lang['Guest'];
$last_update = $row['session_time'];
$user_page = $row['session_page'];
$which_counter = 'guest_counter'; $which_counter = 'guest_counter';
$which_row = 'guest_user_row'; $which_row = 'guest_user_row';
$prev_ip = $row['session_ip'];
}
} }
if ( $view_online ) if ( $view_online )