makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/15342] Check if is resource before close it

Browse source 
PHPBB3-15342
This commit is contained in:
Rubén Calvo 2018-06-27 17:44:41 +02:00
parent bdf3a0c913
commit 0cc77d2c99
3 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
phpBB/includes/acp/acp_database.php
View file

@ -187,7 +187,10 @@ class acp_database
$storage->write_stream($file, $fp); $storage->write_stream($file, $fp);
fclose($fp); if (is_resource($fp))
{
fclose($fp);
}
$storage->track_file($file); $storage->track_file($file);

8
phpBB/phpbb/attachment/upload.php
View file

@ -246,8 +246,14 @@ class upload
{ {
// Move the thumbnail from temp folder to the storage // Move the thumbnail from temp folder to the storage
$fp = fopen($destination, 'rb'); $fp = fopen($destination, 'rb');
$this->storage->write_stream($destination_name, $fp); $this->storage->write_stream($destination_name, $fp);
fclose($fp);
if (is_resource($fp))
{
fclose($fp);
}
$this->storage->track_file($destination_name); $this->storage->track_file($destination_name);
} }
else else

8
phpBB/phpbb/files/filespec_storage.php
View file

@ -445,8 +445,14 @@ class filespec_storage
try try
{ {
$fp = fopen($this->filename, 'rb'); $fp = fopen($this->filename, 'rb');
$storage->write_stream($this->destination_file, $fp); $storage->write_stream($this->destination_file, $fp);
fclose($fp);
if (is_resource($fp))
{
fclose($fp);
}
$storage->track_file($this->destination_file); $storage->track_file($this->destination_file);
} }
catch (\phpbb\storage\exception\exception $e) catch (\phpbb\storage\exception\exception $e)