makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/14132] Use transaction for adding notifications to type table

Browse source 
This will prevent a race condition that might occur by two posts being
submitted at the same time with the notification type IDs not being
cached.

PHPBB3-14132
This commit is contained in:
Marc Alexander 2016-03-08 12:36:29 +01:00
parent f55a61d067
commit 10004c4032
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
phpBB/phpbb/notification/manager.php
View file

@ -923,6 +923,8 @@ class manager
{ {
$notification_type_ids = $this->cache->get('notification_type_ids'); $notification_type_ids = $this->cache->get('notification_type_ids');
$this->db->sql_transaction('begin');
if ($notification_type_ids === false) if ($notification_type_ids === false)
{ {
$notification_type_ids = array(); $notification_type_ids = array();
@ -957,6 +959,8 @@ class manager
$this->cache->put('notification_type_ids', $notification_type_ids); $this->cache->put('notification_type_ids', $notification_type_ids);
} }
$this->db->sql_transaction('commit');
return $notification_type_ids[$notification_type_name]; return $notification_type_ids[$notification_type_name];
} }