makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 22:28:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10141] Use a cache in $auth->_fill_acl() for better performance.

Browse source 
Many sequences being converted are the same. Use a local cache to
convert each sequence once, speeding up the function.

PHPBB3-10141
This commit is contained in:
Bart van Bragt 2011-04-21 04:21:09 -04:00 • committed by Oleg Pudeyev
parent 32bc980ca0
commit 11dd4b54fa
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
phpBB/includes/auth.php
View file

@ -109,6 +109,7 @@ class auth
*/ */
function _fill_acl($user_permissions) function _fill_acl($user_permissions)
{ {
$seq_cache = array();
$this->acl = array(); $this->acl = array();
$user_permissions = explode("\n", $user_permissions); $user_permissions = explode("\n", $user_permissions);
@ -124,9 +125,16 @@ class auth
} }
while ($subseq = substr($seq, $i, 6)) while ($subseq = substr($seq, $i, 6))
{
if (isset($seq_cache[$subseq]))
{
$this->acl[$f] .= $seq_cache[$subseq];
}
else
{ {
// We put the original bitstring into the acl array // We put the original bitstring into the acl array
$this->acl[$f] .= str_pad(base_convert($subseq, 36, 2), 31, 0, STR_PAD_LEFT); $this->acl[$f] .= ($seq_cache[$subseq] = str_pad(base_convert($subseq, 36, 2), 31, 0, STR_PAD_LEFT));
}
$i += 6; $i += 6;
} }
} }