makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 12:28:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #6412 from DaRk1V0iD/ticket/17026

Browse source 
[ticket/17026] Session viewonline not defined in Memberlist
This commit is contained in:
Marc Alexander 2022-08-26 20:47:07 +02:00
commit 12256eabb6
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
phpBB/memberlist.php
View file

@ -1634,17 +1634,20 @@ switch ($mode)
if (count($user_list)) if (count($user_list))
{ {
// Session time?! Session time... // Session time?! Session time...
$sql = 'SELECT session_user_id, MAX(session_time) AS session_time $sql = 'SELECT session_user_id, MAX(session_time) AS session_time, MIN(session_viewonline) AS session_viewonline
FROM ' . SESSIONS_TABLE . ' FROM ' . SESSIONS_TABLE . '
WHERE session_time >= ' . (time() - $config['session_length']) . ' WHERE session_time >= ' . (time() - $config['session_length']) . '
AND ' . $db->sql_in_set('session_user_id', $user_list) . ' AND ' . $db->sql_in_set('session_user_id', $user_list) . '
GROUP BY session_user_id'; GROUP BY session_user_id';
$result = $db->sql_query($sql); $result = $db->sql_query($sql);
$session_times = array(); $session_ary = [];
while ($row = $db->sql_fetchrow($result)) while ($row = $db->sql_fetchrow($result))
{ {
$session_times[$row['session_user_id']] = $row['session_time']; $session_ary[$row['session_user_id']] = [
'session_time' => $row['session_time'],
'session_viewonline' => $row['session_viewonline'],
];
} }
$db->sql_freeresult($result); $db->sql_freeresult($result);
@ -1708,7 +1711,8 @@ switch ($mode)
$id_cache = array(); $id_cache = array();
while ($row = $db->sql_fetchrow($result)) while ($row = $db->sql_fetchrow($result))
{ {
$row['session_time'] = (!empty($session_times[$row['user_id']])) ? $session_times[$row['user_id']] : 0; $row['session_time'] = $session_ary[$row['user_id']]['session_time'] ?? 0;
$row['session_viewonline'] = $session_ary[$row['user_id']]['session_viewonline'] ?? 0;
$row['last_visit'] = (!empty($row['session_time'])) ? $row['session_time'] : $row['user_lastvisit']; $row['last_visit'] = (!empty($row['session_time'])) ? $row['session_time'] : $row['user_lastvisit'];
$id_cache[$row['user_id']] = $row; $id_cache[$row['user_id']] = $row;