makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-27 21:58:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge branch '3.1.x'

Browse source
This commit is contained in:
Tristan Darricau 2015-06-06 11:45:42 +02:00
commit 12c793bcd1
1 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
phpBB/phpbb/passwords/driver/helper.php
View file

@ -153,11 +153,23 @@ class helper
*/ */
public function string_compare($string_a, $string_b) public function string_compare($string_a, $string_b)
{ {
$difference = strlen($string_a) != strlen($string_b); // Return if input variables are not strings or if length does not match
if (!is_string($string_a) || !is_string($string_b) || strlen($string_a) != strlen($string_b))
{
return false;
}
// Use hash_equals() if it's available
if (function_exists('hash_equals'))
{
return hash_equals($string_a, $string_b);
}
$difference = 0;
for ($i = 0; $i < strlen($string_a) && $i < strlen($string_b); $i++) for ($i = 0; $i < strlen($string_a) && $i < strlen($string_b); $i++)
{ {
$difference |= $string_a[$i] != $string_b[$i]; $difference |= ord($string_a[$i]) ^ ord($string_b[$i]);
} }
return $difference === 0; return $difference === 0;