makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-09 12:58:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge remote-tracking branch 'Noxwizard/ticket/10858' into develop-olympus

Browse source 
* Noxwizard/ticket/10858:
  [ticket/10858] Move generic row seeking to DBAL
  [ticket/10858] Tests for row seeking with fetchfield()
  [ticket/10858] Fix MSSQL Native's row seeking behavior
This commit is contained in:
Andreas Fischer 2012-05-09 12:50:13 +02:00
commit 12dbcc7f1e
5 changed files with 69 additions and 104 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
phpBB/includes/db/dbal.php
View file

@ -194,6 +194,49 @@ class dbal
return false; return false;
} }
/**
* Seek to given row number
* rownum is zero-based
*/
function sql_rowseek($rownum, &$query_id)
{
global $cache;
if ($query_id === false)
{
$query_id = $this->query_result;
}
if (isset($cache->sql_rowset[$query_id]))
{
return $cache->sql_rowseek($rownum, $query_id);
}
if ($query_id === false)
{
return false;
}
$this->sql_freeresult($query_id);
$query_id = $this->sql_query($this->last_query_text);
if ($query_id === false)
{
return false;
}
// We do not fetch the row for rownum == 0 because then the next resultset would be the second row
for ($i = 0; $i < $rownum; $i++)
{
if (!$this->sql_fetchrow($query_id))
{
return false;
}
}
return true;
}
/** /**
* Fetch field * Fetch field
* if rownum is false, the current row is used, else it is pointing to the row (zero-based) * if rownum is false, the current row is used, else it is pointing to the row (zero-based)

43
phpBB/includes/db/firebird.php
View file

@ -359,49 +359,6 @@ class dbal_firebird extends dbal
return (sizeof($row)) ? $row : false; return (sizeof($row)) ? $row : false;
} }
/**
* Seek to given row number
* rownum is zero-based
*/
function sql_rowseek($rownum, &$query_id)
{
global $cache;
if ($query_id === false)
{
$query_id = $this->query_result;
}
if (isset($cache->sql_rowset[$query_id]))
{
return $cache->sql_rowseek($rownum, $query_id);
}
if ($query_id === false)
{
return;
}
$this->sql_freeresult($query_id);
$query_id = $this->sql_query($this->last_query_text);
if ($query_id === false)
{
return false;
}
// We do not fetch the row for rownum == 0 because then the next resultset would be the second row
for ($i = 0; $i < $rownum; $i++)
{
if (!$this->sql_fetchrow($query_id))
{
return false;
}
}
return true;
}
/** /**
* Get last inserted id after insert statement * Get last inserted id after insert statement
*/ */

43
phpBB/includes/db/mssql_odbc.php
View file

@ -255,49 +255,6 @@ class dbal_mssql_odbc extends dbal
return ($query_id !== false) ? @odbc_fetch_array($query_id) : false; return ($query_id !== false) ? @odbc_fetch_array($query_id) : false;
} }
/**
* Seek to given row number
* rownum is zero-based
*/
function sql_rowseek($rownum, &$query_id)
{
global $cache;
if ($query_id === false)
{
$query_id = $this->query_result;
}
if (isset($cache->sql_rowset[$query_id]))
{
return $cache->sql_rowseek($rownum, $query_id);
}
if ($query_id === false)
{
return false;
}
$this->sql_freeresult($query_id);
$query_id = $this->sql_query($this->last_query_text);
if ($query_id === false)
{
return false;
}
// We do not fetch the row for rownum == 0 because then the next resultset would be the second row
for ($i = 0; $i < $rownum; $i++)
{
if (!$this->sql_fetchrow($query_id))
{
return false;
}
}
return true;
}
/** /**
* Get last inserted id after insert statement * Get last inserted id after insert statement
*/ */

18
phpBB/includes/db/mssqlnative.php
View file

@ -439,24 +439,6 @@ class dbal_mssqlnative extends dbal
return $row; return $row;
} }
/**
* Seek to given row number
* rownum is zero-based
*/
function sql_rowseek($rownum, &$query_id)
{
global $cache;
if (isset($cache->sql_rowset[$query_id]))
{
return $cache->sql_rowseek($rownum, $query_id);
}
$seek = new result_mssqlnative($query_id);
$row = $seek->seek($rownum);
return ($row = $seek->fetch()) ? $row : false;
}
/** /**
* Get last inserted id after insert statement * Get last inserted id after insert statement
*/ */

26
tests/dbal/select_test.php
View file

@ -125,6 +125,32 @@ class phpbb_dbal_select_test extends phpbb_database_test_case
$this->assertEquals($expected, $ary); $this->assertEquals($expected, $ary);
} }
public static function fetchfield_seek_data()
{
return array(
array(1, 'foobar'),
array(0, 'barfoo'),
array(2, 'bertie'),
);
}
/**
* @dataProvider fetchfield_seek_data
*/
public function test_fetchfield_seek($rownum, $expected)
{
$db = $this->new_dbal();
$result = $db->sql_query('SELECT username_clean
FROM phpbb_users
ORDER BY user_id ASC');
$field = $db->sql_fetchfield('username_clean', $rownum, $result);
$db->sql_freeresult($result);
$this->assertEquals($expected, $field);
}
public static function query_limit_data() public static function query_limit_data()
{ {
return array( return array(