use the "old" approach

git-svn-id: file:///svn/phpbb/trunk@6407 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Meik Sievertsen 2006-09-25 14:32:05 +00:00
parent 8e06ad3829
commit 12f2fbc415

View file

@ -671,88 +671,48 @@ class session
$this->time_now = time(); $this->time_now = time();
} }
switch (SQL_LAYER) // Firstly, delete guest sessions
$sql = 'DELETE FROM ' . SESSIONS_TABLE . '
WHERE session_user_id = ' . ANONYMOUS . '
AND session_time < ' . (int) ($this->time_now - $config['session_length']);
$db->sql_query($sql);
// Get expired sessions, only most recent for each user
$sql = 'SELECT session_user_id, session_page, MAX(session_time) AS recent_time
FROM ' . SESSIONS_TABLE . '
WHERE session_time < ' . ($this->time_now - $config['session_length']) . '
GROUP BY session_user_id, session_page';
$result = $db->sql_query_limit($sql, 10);
$del_user_id = array();
$del_sessions = 0;
while ($row = $db->sql_fetchrow($result));
{ {
case 'mysql4': $sql = 'UPDATE ' . USERS_TABLE . '
case 'mysqli': SET user_lastvisit = ' . (int) $row['recent_time'] . ", user_lastpage = '" . $db->sql_escape($row['session_page']) . "'
// Firstly, delete guest sessions WHERE user_id = " . (int) $row['session_user_id'];
$sql = 'DELETE FROM ' . SESSIONS_TABLE . ' $db->sql_query($sql);
WHERE session_user_id = ' . ANONYMOUS . '
AND session_time < ' . (int) ($this->time_now - $config['session_length']);
$db->sql_query($sql);
// Keep only the most recent session for each user $del_user_id[] = (int) $row['session_user_id'];
// Note: if the user is currently browsing the board, his $del_sessions++;
// last_visit field won't be updated, which I believe should be }
// the normal behavior anyway $db->sql_freeresult($result);
$db->sql_return_on_error(true);
$sql = 'DELETE FROM ' . SESSIONS_TABLE . ' if (sizeof($del_user_id))
USING ' . SESSIONS_TABLE . ' s1, ' . SESSIONS_TABLE . ' s2 {
WHERE s1.session_user_id = s2.session_user_id // Delete expired sessions
AND s1.session_time < s2.session_time'; $sql = 'DELETE FROM ' . SESSIONS_TABLE . '
$db->sql_query($sql); WHERE ' . $db->sql_in_set('session_user_id', $del_user_id) . '
AND session_time < ' . ($this->time_now - $config['session_length']);
$db->sql_query($sql);
}
$db->sql_return_on_error(false); if ($del_sessions < 10)
{
// Update last visit time // Less than 10 sessions, update gc timer ... else we want gc
$sql = 'UPDATE ' . USERS_TABLE. ' u, ' . SESSIONS_TABLE . ' s // called again to delete other sessions
SET u.user_lastvisit = s.session_time, u.user_lastpage = s.session_page set_config('session_last_gc', $this->time_now, true);
WHERE s.session_time < ' . (int) ($this->time_now - $config['session_length']) . '
AND u.user_id = s.session_user_id';
$db->sql_query($sql);
// Delete everything else now
$sql = 'DELETE FROM ' . SESSIONS_TABLE . '
WHERE session_time < ' . (int) ($this->time_now - $config['session_length']);
$db->sql_query($sql);
set_config('session_last_gc', $this->time_now, true);
break;
default:
// Get expired sessions, only most recent for each user
$sql = 'SELECT session_user_id, session_page, MAX(session_time) AS recent_time
FROM ' . SESSIONS_TABLE . '
WHERE session_time < ' . ($this->time_now - $config['session_length']) . '
GROUP BY session_user_id, session_page';
$result = $db->sql_query_limit($sql, 5);
$del_user_id = array();
$del_sessions = 0;
while ($row = $db->sql_fetchrow($result));
{
if ($row['session_user_id'] != ANONYMOUS)
{
$sql = 'UPDATE ' . USERS_TABLE . '
SET user_lastvisit = ' . (int) $row['recent_time'] . ", user_lastpage = '" . $db->sql_escape($row['session_page']) . "'
WHERE user_id = " . (int) $row['session_user_id'];
$db->sql_query($sql);
}
$del_user_id[] = (int) $row['session_user_id'];
$del_sessions++;
}
$db->sql_freeresult($result);
if (sizeof($del_user_id))
{
// Delete expired sessions
$sql = 'DELETE FROM ' . SESSIONS_TABLE . '
WHERE ' . $db->sql_in_set('session_user_id', $del_user_id) . '
AND session_time < ' . ($this->time_now - $config['session_length']);
$db->sql_query($sql);
}
if ($del_sessions < 5)
{
// Less than 5 sessions, update gc timer ... else we want gc
// called again to delete other sessions
set_config('session_last_gc', $this->time_now, true);
}
break;
} }
if ($config['max_autologin_time']) if ($config['max_autologin_time'])