makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 06:08:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10308] fixes sql query, limit it to 1

Browse source 
instead of fetching all posts by user we limit the query to 1 to check if
a user has posts or not

PHPBB3-10308
This commit is contained in:
Dhruv Goel 2012-04-22 00:36:38 +05:30
parent cf303c3478
commit 164054f067
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
phpBB/adm/style/acp_users_overview.html
View file

@ -141,7 +141,7 @@
<dl> <dl>
<dt><label for="delete_type">{L_DELETE_USER}:</label><br /><span>{L_DELETE_USER_EXPLAIN}</span></dt> <dt><label for="delete_type">{L_DELETE_USER}:</label><br /><span>{L_DELETE_USER_EXPLAIN}</span></dt>
<dd> <dd>
<!-- IF USER_TOTAL_POSTS == 0 --> <!-- IF USER_HAS_POSTS == 0 -->
{L_USER_NO_POSTS_DELETE}<input type="hidden" id="delete_type" name="delete_type" value="retain" /> {L_USER_NO_POSTS_DELETE}<input type="hidden" id="delete_type" name="delete_type" value="retain" />
<!-- ELSE --> <!-- ELSE -->
<select id="delete_type" name="delete_type"><option class="sep" value="">{L_SELECT_OPTION}</option><option value="retain">{L_RETAIN_POSTS}</option><option value="remove">{L_DELETE_POSTS}</option></select></dd> <select id="delete_type" name="delete_type"><option class="sep" value="">{L_SELECT_OPTION}</option><option value="retain">{L_RETAIN_POSTS}</option><option value="remove">{L_DELETE_POSTS}</option></select></dd>

8
phpBB/includes/acp/acp_users.php
View file

@ -1009,11 +1009,11 @@ class acp_users
$user_row['posts_in_queue'] = (int) $db->sql_fetchfield('posts_in_queue'); $user_row['posts_in_queue'] = (int) $db->sql_fetchfield('posts_in_queue');
$db->sql_freeresult($result); $db->sql_freeresult($result);
$sql = 'SELECT COUNT(post_id) as user_total_posts $sql = 'SELECT post_id
FROM ' . POSTS_TABLE . ' FROM ' . POSTS_TABLE . '
WHERE poster_id = '. $user_id; WHERE poster_id = '. $user_id;
$result = $db->sql_query($sql); $result = $db->sql_query_limit($sql, 1);
$user_row['user_total_posts'] = (int) $db->sql_fetchfield('user_total_posts'); $user_row['user_has_posts'] = ($db->sql_fetchfield('post_id') ? 1 : 0);
$db->sql_freeresult($result); $db->sql_freeresult($result);
$template->assign_vars(array( $template->assign_vars(array(
@ -1043,7 +1043,7 @@ class acp_users
'USER_EMAIL' => $user_row['user_email'], 'USER_EMAIL' => $user_row['user_email'],
'USER_WARNINGS' => $user_row['user_warnings'], 'USER_WARNINGS' => $user_row['user_warnings'],
'USER_POSTS' => $user_row['user_posts'], 'USER_POSTS' => $user_row['user_posts'],
'USER_TOTAL_POSTS' => $user_row['user_total_posts'], 'USER_HAS_POSTS' => $user_row['user_has_posts'],
'USER_INACTIVE_REASON' => $inactive_reason, 'USER_INACTIVE_REASON' => $inactive_reason,
)); ));