makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11103] Order notifications properly

Browse source 
PHPBB3-11103
This commit is contained in:
Nathaniel Guse 2012-09-08 17:28:13 -05:00
parent 86b801df73
commit 16a0757f2a
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
phpBB/includes/notifications/service.php
View file

@ -46,6 +46,8 @@ class phpbb_notifications_service
* *
* @param array $options Optional options to control what notifications are loaded * @param array $options Optional options to control what notifications are loaded
* user_id User id to load notifications for (Default: $user->data['user_id']) * user_id User id to load notifications for (Default: $user->data['user_id'])
* order_by Order by (Default: time)
* order_dir Order direction (Default: DESC)
* limit Number of notifications to load (Default: 5) * limit Number of notifications to load (Default: 5)
* start Notifications offset (Default: 0) * start Notifications offset (Default: 0)
*/ */
@ -58,12 +60,15 @@ class phpbb_notifications_service
'user_id' => $user->data['user_id'], 'user_id' => $user->data['user_id'],
'limit' => 5, 'limit' => 5,
'start' => 0, 'start' => 0,
'order_by' => 'time',
'order_dir' => 'DESC',
), $options); ), $options);
$notifications = $user_ids = array(); $notifications = $user_ids = array();
$sql = 'SELECT * FROM ' . NOTIFICATIONS_TABLE . ' $sql = 'SELECT * FROM ' . NOTIFICATIONS_TABLE . '
WHERE user_id = ' . (int) $options['user_id']; WHERE user_id = ' . (int) $options['user_id'] . '
ORDER BY ' . $this->db->sql_escape($options['order_by']) . ' ' . $this->db->sql_escape($options['order_dir']);
$result = $this->db->sql_query_limit($sql, $options['limit'], $options['start']); $result = $this->db->sql_query_limit($sql, $options['limit'], $options['start']);
while ($row = $this->db->sql_fetchrow($result)) while ($row = $this->db->sql_fetchrow($result))