From 17e4e5f8c4995f5818411382ccf4b799ddbe0b11 Mon Sep 17 00:00:00 2001
From: Jakub Senko <jakubsenko@gmail.com>
Date: Thu, 4 Sep 2014 13:33:04 +0200
Subject: [PATCH] [ticket/12852] Make get_url_parts handle get variable with no
 value

PHPBB3-12852
---
 phpBB/phpbb/path_helper.php | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/phpBB/phpbb/path_helper.php b/phpBB/phpbb/path_helper.php
index 38dbbab51e..b2758f8654 100644
--- a/phpBB/phpbb/path_helper.php
+++ b/phpBB/phpbb/path_helper.php
@@ -316,7 +316,7 @@ class path_helper
 	* Glue URL parameters together
 	*
 	* @param array $params URL parameters in the form of array(name => value)
-	* @return string Returns the glued string, e.g. name1=value1&amp;name2=value2
+	* @return string Returns the glued string, e.g. name1=value1&amp;name2&amp;name3=value3
 	*/
 	public function glue_url_params($params)
 	{
@@ -324,7 +324,15 @@ class path_helper
 
 		foreach ($params as $key => $value)
 		{
-			$_params[] = $key . '=' . $value;
+			// some parameters do not have value
+			if($value !== null)
+			{
+				$_params[] = $key . '=' . $value;
+			}
+			else
+			{
+				$_params[] = $key;
+			}
 		}
 		return implode('&amp;', $_params);
 	}
@@ -353,7 +361,17 @@ class path_helper
 				{
 					continue;
 				}
-				list($key, $value) = explode('=', $argument, 2);
+				
+				// some parameters don't have value
+				if (strpos($argument, '=') !== false)
+				{
+					list($key, $value) = explode('=', $argument, 2);
+				}
+				else
+				{
+					$key = $argument;
+					$value = null;
+				}
 
 				if ($key === '')
 				{