makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Perhaps temporary, perhaps permanent INNER JOIN fix

Browse source 
git-svn-id: file:///svn/phpbb/trunk@76 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Paul S. Owen 2001-03-02 18:19:18 +00:00
parent d2ec2d3874
commit 1f13c1bb65
1 changed files with 19 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
phpBB/viewforum.php
View file

@ -29,7 +29,9 @@ if(isset($forum_id))
{ {
$sql = "SELECT f.forum_type, f.forum_name, u.username, u.user_id $sql = "SELECT f.forum_type, f.forum_name, u.username, u.user_id
FROM ".FORUMS_TABLE." f, ".FORUM_MODS_TABLE." fm, ".USERS_TABLE." u FROM ".FORUMS_TABLE." f, ".FORUM_MODS_TABLE." fm, ".USERS_TABLE." u
WHERE f.forum_id = '$forum_id' AND fm.forum_id = '$forum_id' AND u.user_id = fm.user_id"; WHERE f.forum_id = '$forum_id'
AND fm.forum_id = '$forum_id'
AND u.user_id = fm.user_id";
} }
else else
{ {
@ -41,6 +43,15 @@ if(!$result = $db->sql_query($sql))
error_die($db, QUERY_ERROR); error_die($db, QUERY_ERROR);
} }
$pagetype = "viewforum";
$page_title = "View Forum - $forum_name";
include('page_header.'.$phpEx);
//
// Add checking for private forums here!!
//
// If the query dosan't return any rows this isn't a valid forum. Inform the user. // If the query dosan't return any rows this isn't a valid forum. Inform the user.
if(!$total_rows = $db->sql_numrows($result)) if(!$total_rows = $db->sql_numrows($result))
{ {
@ -61,13 +72,6 @@ for($x = 0; $x < $db->sql_numrows($result); $x++)
$forum_moderators .= "<a href=\"profile.$phpEx?mode=viewprofile&user_id=".$forum_row[$x]["user_id"]."\">".$forum_row[$x]["username"]."</a>"; $forum_moderators .= "<a href=\"profile.$phpEx?mode=viewprofile&user_id=".$forum_row[$x]["user_id"]."\">".$forum_row[$x]["username"]."</a>";
} }
$pagetype = "viewforum";
$page_title = "View Forum - $forum_name";
include('page_header.'.$phpEx);
// Add checking for private forums here!!
$template->set_block("body", "topicrow", "topics"); $template->set_block("body", "topicrow", "topics");
if(!isset($start)) if(!isset($start))
@ -75,7 +79,13 @@ if(!isset($start))
$start = 0; $start = 0;
} }
$sql = "SELECT t.*, u.username, p.post_time FROM " . TOPICS_TABLE ." t INNER JOIN ". USERS_TABLE. " u ON t.topic_poster = u.user_id LEFT JOIN ".POSTS_TABLE." p ON p.post_id = t.topic_last_post_id WHERE t.forum_id = '$forum_id' ORDER BY topic_time DESC LIMIT $start, $topics_per_page"; $sql = "SELECT t.*, u.username, p.post_time
FROM " . TOPICS_TABLE ." t
LEFT JOIN ". USERS_TABLE. " u ON t.topic_poster = u.user_id
LEFT JOIN ".POSTS_TABLE." p ON p.post_id = t.topic_last_post_id
WHERE t.forum_id = '$forum_id'
ORDER BY topic_time DESC
LIMIT $start, $topics_per_page";
if(!$t_result = $db->sql_query($sql)) if(!$t_result = $db->sql_query($sql))
{ {
error_die($db, QUERY_ERROR); error_die($db, QUERY_ERROR);