makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/12175] Do not use admin account for file size limit test

Browse source 
PHPBB3-12175
This commit is contained in:
Joas Schilling 2014-02-09 23:48:34 +01:00
parent 07f19647f4
commit 1fdd01275e
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
tests/functional/fileupload_form_test.php
View file

@ -19,7 +19,6 @@ class phpbb_functional_fileupload_form_test extends phpbb_functional_test_case
parent::setUp(); parent::setUp();
$this->path = __DIR__ . '/fixtures/files/'; $this->path = __DIR__ . '/fixtures/files/';
$this->add_lang('posting'); $this->add_lang('posting');
$this->login();
} }
public function tearDown() public function tearDown()
@ -63,25 +62,33 @@ class phpbb_functional_fileupload_form_test extends phpbb_functional_test_case
public function test_empty_file() public function test_empty_file()
{ {
$this->login();
$crawler = $this->upload_file('empty.png', 'image/png'); $crawler = $this->upload_file('empty.png', 'image/png');
$this->assertEquals($this->lang('EMPTY_FILEUPLOAD'), $crawler->filter('p.error')->text()); $this->assertEquals($this->lang('EMPTY_FILEUPLOAD'), $crawler->filter('p.error')->text());
} }
public function test_invalid_extension() public function test_invalid_extension()
{ {
$this->login();
$crawler = $this->upload_file('illegal-extension.bif', 'application/octet-stream'); $crawler = $this->upload_file('illegal-extension.bif', 'application/octet-stream');
$this->assertEquals($this->lang('DISALLOWED_EXTENSION', 'bif'), $crawler->filter('p.error')->text()); $this->assertEquals($this->lang('DISALLOWED_EXTENSION', 'bif'), $crawler->filter('p.error')->text());
} }
public function test_too_large() public function test_too_large()
{ {
$this->markTestIncomplete('Functional tests use an admin account which ignores maximum upload size.'); $this->create_user('fileupload');
$this->login('fileupload');
$crawler = $this->upload_file('too-large.png', 'image/png'); $crawler = $this->upload_file('too-large.png', 'image/png');
$this->assertEquals($this->lang('WRONG_FILESIZE', '256', 'KiB'), $crawler->filter('p.error')->text()); $this->assertEquals($this->lang('WRONG_FILESIZE', '256', 'KiB'), $crawler->filter('p.error')->text());
} }
public function test_valid_file() public function test_valid_file()
{ {
$this->login();
$crawler = $this->upload_file('valid.jpg', 'image/jpeg'); $crawler = $this->upload_file('valid.jpg', 'image/jpeg');
// Ensure there was no error message rendered // Ensure there was no error message rendered