From 227ae48255f7bfb2dd4387c83df3af5320102615 Mon Sep 17 00:00:00 2001 From: Fyorl Date: Wed, 15 Aug 2012 06:10:53 +0800 Subject: [PATCH] [feature/attach-dl] Optimised an sql query PHPBB3-11042 --- phpBB/includes/functions_download.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/phpBB/includes/functions_download.php b/phpBB/includes/functions_download.php index 182fce222b..b6371dbecc 100644 --- a/phpBB/includes/functions_download.php +++ b/phpBB/includes/functions_download.php @@ -687,7 +687,7 @@ function phpbb_download_handle_pm_auth($db, $auth, $user_id, $msg_id) function phpbb_download_check_pm_auth($db, $user_id, $msg_id) { // Check if the attachment is within the users scope... - $sql = 'SELECT user_id, author_id + $sql = 'SELECT msg_id FROM ' . PRIVMSGS_TO_TABLE . ' WHERE msg_id = ' . (int) $msg_id . ' AND ( @@ -695,7 +695,7 @@ function phpbb_download_check_pm_auth($db, $user_id, $msg_id) OR author_id = ' . (int) $user_id . ' )'; $result = $db->sql_query_limit($sql, 1); - $allowed = $db->sql_fetchrow($result); + $allowed = (bool) $db->sql_fetchfield('msg_id'); $db->sql_freeresult($result); return $allowed;