From 27550ce59b8a66a6f1a988b8471711b630eaf745 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sun, 20 Apr 2025 07:55:28 +0200 Subject: [PATCH] [ticket/17493] Remove not needed function in migration and fix type hinting PHPBB-17493 --- .../phpbb/db/migration/data/v400/remove_jabber.php | 2 +- .../db/migration/data/v400/remove_notify_type.php | 14 -------------- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/phpBB/phpbb/db/migration/data/v400/remove_jabber.php b/phpBB/phpbb/db/migration/data/v400/remove_jabber.php index c297ef0a8a..5ff6b1e9b5 100644 --- a/phpBB/phpbb/db/migration/data/v400/remove_jabber.php +++ b/phpBB/phpbb/db/migration/data/v400/remove_jabber.php @@ -101,7 +101,7 @@ class remove_jabber extends migration ]; } - public function move_jabber_to_email_notifications(int $start = 0) + public function move_jabber_to_email_notifications(?int $start = 0) { $limit = 1000; diff --git a/phpBB/phpbb/db/migration/data/v400/remove_notify_type.php b/phpBB/phpbb/db/migration/data/v400/remove_notify_type.php index a4b3cce8ed..7ed606cd80 100644 --- a/phpBB/phpbb/db/migration/data/v400/remove_notify_type.php +++ b/phpBB/phpbb/db/migration/data/v400/remove_notify_type.php @@ -47,18 +47,4 @@ class remove_notify_type extends migration ] ]; } - - public function update_data() - { - return [ - ['custom', [[$this, 'remove_jabber_user_notifications']]], - ]; - } - - protected function remove_jabber_user_notifications(): void - { - $sql = 'DELETE FROM ' . $this->tables['user_notifications'] . " - WHERE method = 'notification.method.jabber'"; - $this->db->sql_query($sql); - } }