makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-13 14:58:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[feature/auth-refactor] Forgot @inheritdoc on methods

Browse source 
PHPBB3-9734
This commit is contained in:
Joseph Warner 2013-06-28 13:43:41 -04:00
parent 24e323d593
commit 27f0b9ff43
3 changed files with 54 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
phpBB/includes/auth/provider_apache.php
View file

@ -42,6 +42,9 @@ class phpbb_auth_provider_apache implements phpbb_auth_provider_interface
$this->php_ext = $php_ext; $this->php_ext = $php_ext;
} }
/**
* {@inheritdoc}
*/
public function init() public function init()
{ {
if (!$this->request->is_set('PHP_AUTH_USER', phpbb_request_interface::SERVER) || $this->user->data['username'] !== htmlspecialchars_decode($this->request->server('PHP_AUTH_USER'))) if (!$this->request->is_set('PHP_AUTH_USER', phpbb_request_interface::SERVER) || $this->user->data['username'] !== htmlspecialchars_decode($this->request->server('PHP_AUTH_USER')))
@ -51,6 +54,9 @@ class phpbb_auth_provider_apache implements phpbb_auth_provider_interface
return false; return false;
} }
/**
* {@inheritdoc}
*/
public function login($username, $password) public function login($username, $password)
{ {
// do not allow empty password // do not allow empty password
@ -138,6 +144,9 @@ class phpbb_auth_provider_apache implements phpbb_auth_provider_interface
); );
} }
/**
* {@inheritdoc}
*/
public function autologin() public function autologin()
{ {
if (!$this->request->is_set('PHP_AUTH_USER', phpbb_request_interface::SERVER)) if (!$this->request->is_set('PHP_AUTH_USER', phpbb_request_interface::SERVER))
@ -226,6 +235,9 @@ class phpbb_auth_provider_apache implements phpbb_auth_provider_interface
); );
} }
/**
* {@inheritdoc}
*/
public function validate_session($user) public function validate_session($user)
{ {
// Check if PHP_AUTH_USER is set and handle this case // Check if PHP_AUTH_USER is set and handle this case
@ -245,11 +257,17 @@ class phpbb_auth_provider_apache implements phpbb_auth_provider_interface
return false; return false;
} }
/**
* {@inheritdoc}
*/
public function acp($new) public function acp($new)
{ {
return; return;
} }
/**
* {@inheritdoc}
*/
public function logout($data, $new_session) public function logout($data, $new_session)
{ {
return; return;

18
phpBB/includes/auth/provider_db.php
View file

@ -45,11 +45,17 @@ class phpbb_auth_provider_db implements phpbb_auth_provider_interface
$this->php_ext = $php_ext; $this->php_ext = $php_ext;
} }
/**
* {@inheritdoc}
*/
public function init() public function init()
{ {
return; return;
} }
/**
* {@inheritdoc}
*/
public function login($username, $password) public function login($username, $password)
{ {
// Auth plugins get the password untrimmed. // Auth plugins get the password untrimmed.
@ -297,21 +303,33 @@ class phpbb_auth_provider_db implements phpbb_auth_provider_interface
); );
} }
/**
* {@inheritdoc}
*/
public function autologin() public function autologin()
{ {
return; return;
} }
/**
* {@inheritdoc}
*/
public function acp($new) public function acp($new)
{ {
return; return;
} }
/**
* {@inheritdoc}
*/
public function logout($data, $new_session) public function logout($data, $new_session)
{ {
return; return;
} }
/**
* {@inheritdoc}
*/
public function validate_session($user) public function validate_session($user)
{ {
return; return;

18
phpBB/includes/auth/provider_ldap.php
View file

@ -38,6 +38,9 @@ class phpbb_auth_provider_ldap implements phpbb_auth_provider_interface
$this->user = $user; $this->user = $user;
} }
/**
* {@inheritdoc}
*/
public function init() public function init()
{ {
if (!@extension_loaded('ldap')) if (!@extension_loaded('ldap'))
@ -106,6 +109,9 @@ class phpbb_auth_provider_ldap implements phpbb_auth_provider_interface
return false; return false;
} }
/**
* {@inheritdoc}
*/
public function login($username, $password) public function login($username, $password)
{ {
// do not allow empty password // do not allow empty password
@ -277,11 +283,17 @@ class phpbb_auth_provider_ldap implements phpbb_auth_provider_interface
); );
} }
/**
* {@inheritdoc}
*/
public function autologin() public function autologin()
{ {
return; return;
} }
/**
* {@inheritdoc}
*/
public function acp($new) public function acp($new)
{ {
$tpl = ' $tpl = '
@ -356,11 +368,17 @@ class phpbb_auth_provider_ldap implements phpbb_auth_provider_interface
return str_replace(array('*', '\\', '(', ')'), array('\\*', '\\\\', '\\(', '\\)'), $string); return str_replace(array('*', '\\', '(', ')'), array('\\*', '\\\\', '\\(', '\\)'), $string);
} }
/**
* {@inheritdoc}
*/
public function logout($data, $new_session) public function logout($data, $new_session)
{ {
return; return;
} }
/**
* {@inheritdoc}
*/
public function validate_session($user) public function validate_session($user)
{ {
return; return;