makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #5301 from senky/ticket/11500

Browse source 
[ticket/11500] Remove unnamed input
This commit is contained in:
Marc Alexander 2018-10-08 21:42:46 +02:00
commit 2c74cb71b5
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
2 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
phpBB/adm/style/acp_profile.html
View file

@ -238,7 +238,7 @@
<form id="profile_fields" method="post" action="{U_ACTION}"> <form id="profile_fields" method="post" action="{U_ACTION}">
<fieldset class="quick"> <fieldset class="quick">
<input class="text small" type="text" name="field_ident" /> <select name="field_type">{S_TYPE_OPTIONS}</select> <select name="field_type">{S_TYPE_OPTIONS}</select>
<input class="button1" type="submit" name="submit" value="{L_CREATE_NEW_FIELD}" /> <input class="button1" type="submit" name="submit" value="{L_CREATE_NEW_FIELD}" />
<input type="hidden" name="create" value="1" /> <input type="hidden" name="create" value="1" />
{S_FORM_TOKEN} {S_FORM_TOKEN}

15
tests/functional/acp_profile_field_test.php
View file

@ -28,18 +28,20 @@ class phpbb_functional_acp_profile_field_test extends phpbb_functional_test_case
public function data_add_profile_field() public function data_add_profile_field()
{ {
return array( return array(
array('bool', 'profilefields.type.bool', array('profilefields.type.bool',
array( array(
'field_ident' => 'bool',
'lang_name' => 'bool',
'lang_options[0]' => 'foo', 'lang_options[0]' => 'foo',
'lang_options[1]' => 'bar', 'lang_options[1]' => 'bar',
), ),
array(),
), ),
array('dropdown', 'profilefields.type.dropdown', array('profilefields.type.dropdown',
array( array(
'field_ident' => 'dropdown',
'lang_name' => 'dropdown',
'lang_options' => "foo\nbar\nbar\nfoo", 'lang_options' => "foo\nbar\nbar\nfoo",
), ),
array(),
), ),
); );
} }
@ -47,13 +49,12 @@ class phpbb_functional_acp_profile_field_test extends phpbb_functional_test_case
/** /**
* @dataProvider data_add_profile_field * @dataProvider data_add_profile_field
*/ */
public function test_add_profile_field($name, $type, $page1_settings, $page2_settings) public function test_add_profile_field($type, $page1_settings)
{ {
// Custom profile fields page // Custom profile fields page
$crawler = self::request('GET', 'adm/index.php?i=acp_profile&mode=profile&sid=' . $this->sid); $crawler = self::request('GET', 'adm/index.php?i=acp_profile&mode=profile&sid=' . $this->sid);
// these language strings are html // these language strings are html
$form = $crawler->selectButton('Create new field')->form(array( $form = $crawler->selectButton('Create new field')->form(array(
'field_ident' => $name,
'field_type' => $type, 'field_type' => $type,
)); ));
$crawler = self::submit($form); $crawler = self::submit($form);
@ -63,7 +64,7 @@ class phpbb_functional_acp_profile_field_test extends phpbb_functional_test_case
$crawler = self::submit($form); $crawler = self::submit($form);
// Fill form for profile field specific options // Fill form for profile field specific options
$form = $crawler->selectButton('Save')->form($page2_settings); $form = $crawler->selectButton('Save')->form();
$crawler= self::submit($form); $crawler= self::submit($form);
$this->assertContainsLang('ADDED_PROFILE_FIELD', $crawler->text()); $this->assertContainsLang('ADDED_PROFILE_FIELD', $crawler->text());