makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-27 21:58:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/9388] Add support for making <select> options able to toggle settings.

Browse source 
PHPBB3-9388
This commit is contained in:
Cesar G 2014-05-06 17:50:22 -07:00
parent d4fc060bcd
commit 2e025f1655
2 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
phpBB/assets/javascript/core.js
View file

@ -1475,6 +1475,21 @@ phpbb.toggleDisplay = function(id, action, type) {
$('#' + id).css('display', ((action === 1) ? type : 'none')); $('#' + id).css('display', ((action === 1) ? type : 'none'));
} }
/**
* Toggle additional settings based on the selected
* option of select element.
*
* @param jQuery el jQuery select element object.
* @return undefined
*/
phpbb.toggleSelectSettings = function(el) {
el.children().each(function() {
var option = $(this),
setting = $(option.data('toggle-setting'));
setting.toggle(option.is(':selected'));
});
};
/** /**
* Get function from name. * Get function from name.
* Based on http://stackoverflow.com/a/359910 * Based on http://stackoverflow.com/a/359910
@ -1516,6 +1531,16 @@ $(document).ready(function() {
// Update browser history URL to point to specific post in viewtopic.php // Update browser history URL to point to specific post in viewtopic.php
// when using view=unread#unread link. // when using view=unread#unread link.
phpbb.history.replaceUrl($('#unread[data-url]').data('url')); phpbb.history.replaceUrl($('#unread[data-url]').data('url'));
// Hide settings that are not selected via select element.
$('select[data-toggable-settings]').each(function() {
var select = $(this);
select.change(function() {
phpbb.toggleSelectSettings(select);
});
phpbb.toggleSelectSettings(select);
});
}); });
})(jQuery); // Avoid conflicts with other libraries })(jQuery); // Avoid conflicts with other libraries

3
phpBB/includes/functions_acp.php
View file

@ -364,8 +364,9 @@ function build_cfg_template($tpl_type, $key, &$new, $config_key, $vars)
if ($tpl_type[0] == 'select') if ($tpl_type[0] == 'select')
{ {
$size = (isset($tpl_type[1])) ? (int) $tpl_type[1] : 1; $size = (isset($tpl_type[1])) ? (int) $tpl_type[1] : 1;
$data_toggle = (!empty($tpl_type[2])) ? ' data-toggable-settings="true"' : '';
$tpl = '<select id="' . $key . '" name="' . $name . '"' . (($size > 1) ? ' size="' . $size . '"' : '') . '>' . $return . '</select>'; $tpl = '<select id="' . $key . '" name="' . $name . '"' . (($size > 1) ? ' size="' . $size . '"' : '') . $data_toggle . '>' . $return . '</select>';
} }
else else
{ {