makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 22:28:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/12597] Fix test file

Browse source 
Fix bug of test_no_task that expected a message where none was supposed
to exist.

PHPBB3-12597
This commit is contained in:
LEZY Thomas 2014-05-29 17:40:57 +02:00
parent 335faafae8
commit 2f2e404639
1 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
tests/console/cron/run_test.php
View file

@ -61,6 +61,7 @@ class phpbb_console_command_cron_run_test extends phpbb_database_test_case
$this->assertSame('', $command_tester->getDisplay()); $this->assertSame('', $command_tester->getDisplay());
$this->assertSame(true, $this->task->executed); $this->assertSame(true, $this->task->executed);
$this->assertSame(0, $exit_status); $this->assertSame(0, $exit_status);
$this->assertSame(false, $this->lock->owns_lock());
} }
public function test_verbose_mode() public function test_verbose_mode()
@ -71,6 +72,7 @@ class phpbb_console_command_cron_run_test extends phpbb_database_test_case
$this->assertContains('RUNNING_TASK', $command_tester->getDisplay()); $this->assertContains('RUNNING_TASK', $command_tester->getDisplay());
$this->assertSame(true, $this->task->executed); $this->assertSame(true, $this->task->executed);
$this->assertSame(0, $exit_status); $this->assertSame(0, $exit_status);
$this->assertSame(false, $this->lock->owns_lock());
} }
public function test_error_lock() public function test_error_lock()
@ -92,8 +94,22 @@ class phpbb_console_command_cron_run_test extends phpbb_database_test_case
$command_tester = $this->get_command_tester(); $command_tester = $this->get_command_tester();
$exit_status = $command_tester->execute(array('command' => $this->command_name)); $exit_status = $command_tester->execute(array('command' => $this->command_name));
$this->assertSame('', $command_tester->getDisplay());
$this->assertSame(0, $exit_status);
$this->assertSame(false, $this->lock->owns_lock());
}
public function test_no_task_verbose()
{
$tasks = array(
);
$this->cron_manager = new \phpbb\cron\manager($tasks, $phpbb_root_path, $pathEx);
$command_tester = $this->get_command_tester();
$exit_status = $command_tester->execute(array('command' => $this->command_name, '--verbose' => true));
$this->assertContains('CRON_NO_TASK', $command_tester->getDisplay()); $this->assertContains('CRON_NO_TASK', $command_tester->getDisplay());
$this->assertSame(0, $exit_status); $this->assertSame(0, $exit_status);
$this->assertSame(false, $this->lock->owns_lock());
} }
public function test_arg_valid() public function test_arg_valid()
@ -104,6 +120,7 @@ class phpbb_console_command_cron_run_test extends phpbb_database_test_case
$this->assertSame('', $command_tester->getDisplay()); $this->assertSame('', $command_tester->getDisplay());
$this->assertSame(true, $this->task->executed); $this->assertSame(true, $this->task->executed);
$this->assertSame(0, $exit_status); $this->assertSame(0, $exit_status);
$this->assertSame(false, $this->lock->owns_lock());
} }
public function test_arg_invalid() public function test_arg_invalid()
@ -114,6 +131,7 @@ class phpbb_console_command_cron_run_test extends phpbb_database_test_case
$this->assertContains('CRON_NO_SUCH_TASK', $command_tester->getDisplay()); $this->assertContains('CRON_NO_SUCH_TASK', $command_tester->getDisplay());
$this->assertSame(false, $this->task->executed); $this->assertSame(false, $this->task->executed);
$this->assertSame(2, $exit_status); $this->assertSame(2, $exit_status);
$this->assertSame(false, $this->lock->owns_lock());
} }
public function test_arg_valid_verbose() public function test_arg_valid_verbose()
@ -124,6 +142,7 @@ class phpbb_console_command_cron_run_test extends phpbb_database_test_case
$this->assertContains('RUNNING_TASK', $command_tester->getDisplay()); $this->assertContains('RUNNING_TASK', $command_tester->getDisplay());
$this->assertSame(true, $this->task->executed); $this->assertSame(true, $this->task->executed);
$this->assertSame(0, $exit_status); $this->assertSame(0, $exit_status);
$this->assertSame(false, $this->lock->owns_lock());
} }
public function get_command_tester() public function get_command_tester()