From 2f53761eaf8fd6991a7af4e31c8ecefe30013cab Mon Sep 17 00:00:00 2001 From: rxu Date: Sun, 3 Jul 2016 01:26:42 +0700 Subject: [PATCH] [ticket/14703] Fix parent module selection for custom extension modules PHPBB3-14703 --- phpBB/phpbb/db/migration/tool/module.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/phpBB/phpbb/db/migration/tool/module.php b/phpBB/phpbb/db/migration/tool/module.php index 035625b095..d01b659a0e 100644 --- a/phpBB/phpbb/db/migration/tool/module.php +++ b/phpBB/phpbb/db/migration/tool/module.php @@ -210,12 +210,15 @@ class module implements \phpbb\db\migration\tool\tool_interface } // The "manual" way + // More than 1 module with the same module_basename may exist + // Thus use empty module_basename to select a category as a parent if (!is_numeric($parent)) { $sql = 'SELECT module_id FROM ' . $this->modules_table . " WHERE module_langname = '" . $this->db->sql_escape($parent) . "' - AND module_class = '" . $this->db->sql_escape($class) . "'"; + AND module_class = '" . $this->db->sql_escape($class) . "' + AND module_basename = ''"; $result = $this->db->sql_query($sql); $module_id = $this->db->sql_fetchfield('module_id'); $this->db->sql_freeresult($result);