diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php index c530328658..b5a37e6bb3 100644 --- a/phpBB/includes/functions.php +++ b/phpBB/includes/functions.php @@ -1287,7 +1287,7 @@ function page_header($page_title = '') 'U_INDEX' => 'index.'.$phpEx.$SID, 'U_SEARCH' => 'search.'.$phpEx.$SID, 'U_REGISTER' => 'ucp.'.$phpEx.$SID.'&mode=register', - 'U_PROFILE' => 'ucp.'.$phpEx.$SID.'&mode=editprofile', + 'U_PROFILE' => 'ucp.'.$phpEx.$SID, 'U_MODCP' => 'mcp.'.$phpEx.$SID, 'U_FAQ' => 'faq.'.$phpEx.$SID, 'U_SEARCH_SELF' => 'search.'.$phpEx.$SID.'&search_id=egosearch', diff --git a/phpBB/language/en/lang_main.php b/phpBB/language/en/lang_main.php index f73c482d17..bec8a5b55d 100644 --- a/phpBB/language/en/lang_main.php +++ b/phpBB/language/en/lang_main.php @@ -628,39 +628,36 @@ $lang = array( 'UCP' => 'User Control Panel', + 'UCP_OPTIONS' => 'Options', - 'UCP_Priv_messages' => 'Private Messages', - 'SUBSCRIBED_TOPICS' => 'Subscribed Topics', - 'SUBSCRIBED_FORUMS' => 'Subscribed Forums', - 'WELCOME_USERCP' => 'Welcome to your User Control Panel', - 'UCP_WELCOME_MESSAGE' => 'This is the UCP welcome message some text should go here that says something usefull, however I can\'t for the life of me think of anything to put so if someone coudl come up with something that would be great. Thanks.', - 'BUDDY_LIST' => 'Buddy List', - 'ONLINE_BUDDIES' => 'Buddies Currently Online', - 'UNREAD_PM' => 'Unread PMs', - - 'Registration_information' => 'Registration Information', - 'Preferances' => 'Preferances', - 'Avatar_settings' => 'Avatar Settings', - 'Signature_settings' => 'Signature Settings', 'UCP_MAIN' => 'Overview', - 'UCP_PREFERENCES' => 'Preferences', - 'UCP_PERSONAL' => 'Personal Settings', - 'UCP_VIEW' => 'Viewing Posts', - 'UCP_POST' => 'Posting Messages', + 'UCP_FRONT' => 'Front page', + 'UCP_WELCOME' => 'Welcome to the User Control Panel. From here you can monitor, view and update your profile, preferences, subscribed forums and topics. You can also send messages to other users (if permitted). Please ensure you read any announcements before continuing.', + 'IMPORTANT_NEWS'=> 'Important announcements', + 'YOUR_DETAILS' => 'Your activity', + 'ONLINE_BUDDIES'=> 'Online Buddies', + 'UNREAD_NO_PM' => 'You have no unread private messages', + 'UNREAD_PM' => 'You have 1 unread private messages', + 'UNREAD_PMS' => 'You have $d unread private messages', + 'TOTAL_NO_PM' => '0 private messages in total', + 'TOTAL_PM' => '1 private messages in total', + 'TOTAL_PMS' => '$d private messages in total', - - 'UCP_MESSAGING' => 'Private Messaging', + 'UCP_WATCHED' => 'Watched items', + 'WATCHED_FORUMS' => 'Watched Forums', + 'WATCHED_TOPICS' => 'Watched Topics', + 'NO_WATCHED_FORUMS' => 'You are not watching any forums.', + 'NO_WATCHED_TOPICS' => 'You are not watching any topics.', - 'UCP_LISTS' => 'Buddy/Ignore Lists', + 'UCP_PROFILE' => 'Profile', - 'UCP_PROFILE' => 'Your Profile', 'UCP_REG_DETAILS' => 'Registration details', - 'UCP_AVATAR' => 'Your avatar', + 'UCP_PROFILE_INFO' => 'Your Profile', 'PROFILE_INFO_NOTICE' => 'Please note that this information will be viewable to other members. Be careful when including any personal details. Any fields marked with a * must be completed.', 'WEBSITE' => 'Website', 'LOCATION' => 'Location', @@ -682,31 +679,7 @@ $lang = array( 'SIGNATURE_EXPLAIN' => 'This is a block of text that can be added to posts you make. There is a %d character limit', 'SIGNATURE_TOO_LONG'=> 'Your signature is too long.', - - 'No_user_id_specified' => 'Sorry but that user does not exist', - 'Wrong_Profile' => 'You cannot modify a profile that is not your own.', - 'Only_one_avatar' => 'Only one type of avatar can be specified', - 'File_no_data' => 'The file at the URL you gave contains no data', - 'No_connection_URL' => 'A connection could not be made to the URL you gave', - 'Incomplete_URL' => 'The URL you entered is incomplete', - 'Wrong_remote_avatar_format' => 'The URL of the remote avatar is not valid', - 'No_send_account_inactive' => 'Sorry, but your password cannot be retrieved because your account is currently inactive. Please contact the forum administrator for more information', - 'Always_smile' => 'Always enable Smilies', - 'Always_html' => 'Always allow HTML', - 'Always_bbcode' => 'Always allow BBCode', - 'Always_add_sig' => 'Always attach my signature', - 'Always_notify' => 'Always notify me of replies', - 'Always_notify_explain' => 'Sends an email when someone replies to a topic you have posted in. This can be changed whenever you post', - 'Board_style' => 'Board Style', - 'DEFAULT_STYLE' => 'Default style', - 'No_themes' => 'No Themes In database', - - - 'Date_format' => 'Date format', - 'Date_format_explain' => 'The syntax used is identical to the PHP date() function', - - 'Public_view_email' => 'Always show my Email Address', - + 'UCP_AVATAR' => 'Your avatar', 'AVATAR' => 'Avatar', 'AVATAR_EXPLAIN' => 'Displays a small graphic image below your details in posts. Only one image can be displayed at a time, its width can be no greater than %d pixels, a height no greater than %d pixels and a file size no more than %dkB.', 'DELETE_AVATAR' => 'Delete Image', @@ -719,16 +692,55 @@ $lang = array( 'AVATAR_URL' => 'URL of Avatar Image', 'AVATAR_GALLERY' => 'Select from gallery', 'SHOW_GALLERY' => 'Show gallery', + + + 'UCP_PREFERENCES' => 'Preferences', + + 'UCP_PERSONAL' => 'Personal Settings', + 'HIDE_ONLINE' => 'Hide my online status', + 'NOTIFY_ON_PM' => 'Email me on new private messages', + 'POPUP_ON_PM' => 'Pop up window on new private message', + 'SHOW_EMAIL' => 'Users can contact me by email', + 'BOARD_STYLE' => 'My board style', + 'BOARD_LANGUAGE' => 'My language', + 'BOARD_TIMEZONE' => 'My timezone', + 'BOARD_DST' => 'Daylight Saving Time is in effect', + 'BOARD_DATE_FORMAT' => 'My date format', + 'BOARD_DATE_FORMAT_EXPLAIN' => 'The syntax used is identical to the PHP date() function', + + 'UCP_VIEW' => 'Viewing Posts', + + 'UCP_POST' => 'Posting Messages', + 'DEFAULT_SMILE' => 'Enable smilies by default', + 'DEFAULT_HTML' => 'Enable HTML by default', + 'DEFAULT_BBCODE' => 'Enable BBCode by default', + 'DEFAULT_ADD_SIG' => 'Attach my signature by default', + 'DEFAULT_NOTIFY' => 'Notify me upon replies by default', + + + 'UCP_MESSAGING' => 'Private Messaging', + + + 'UCP_LISTS' => 'Buddy/Ignore Lists', + + + 'No_user_id_specified' => 'Sorry but that user does not exist', + 'Wrong_Profile' => 'You cannot modify a profile that is not your own.', + 'Only_one_avatar' => 'Only one type of avatar can be specified', + 'File_no_data' => 'The file at the URL you gave contains no data', + 'No_connection_URL' => 'A connection could not be made to the URL you gave', + 'Incomplete_URL' => 'The URL you entered is incomplete', + 'Wrong_remote_avatar_format' => 'The URL of the remote avatar is not valid', + 'No_send_account_inactive' => 'Sorry, but your password cannot be retrieved because your account is currently inactive. Please contact the forum administrator for more information', + + + 'Select_avatar' => 'Select avatar', 'Return_profile' => 'Cancel avatar', 'Select_category' => 'Select category', - 'Notify_on_privmsg' => 'Notify on new Private Message', - 'Popup_on_privmsg' => 'Pop up window on new Private Message', - 'Popup_on_privmsg_explain' => 'Some templates may open a new window to inform you when new private messages arrive', - 'Hide_user' => 'Hide your online status', 'Profile_updated' => 'Your profile has been updated', 'Profile_updated_inactive' => 'Your profile has been updated, however you have changed vital details thus your account is now inactive. Check your email to find out how to reactivate your account, or if admin activation is require wait for the administrator to reactivate your account', diff --git a/phpBB/templates/subSilver/ucp_main.html b/phpBB/templates/subSilver/ucp_main.html index 2c06042922..2f9b66f579 100644 --- a/phpBB/templates/subSilver/ucp_main.html +++ b/phpBB/templates/subSilver/ucp_main.html @@ -1,75 +1,127 @@ - {L_UCP} - - - - - - - - - - - - - - -
{L_SUBSCRIBED_TOPICS}
{subscribed_topics.TOPIC_FOLDER_IMG}{subscribed_topics.NEWEST_POST_IMG}{subscribed_topics.TOPIC_TITLE}{subscribed_topics.UNSUBSCRIBE_IMG}
-
- - - - - - - - - - - -
{L_SUBSCRIBED_FORUMS}
{subscribed_forums.FORUM_FOLDER_IMG}{subscribed_forums.NEWEST_FORUM_POST_IMG}{subscribed_forums.FORUM_NAME}{subscribed_forums.UNSUBSCRIBE_IMG}
- - - - - - - - - -
{L_WELCOME_USERCP}
{UCP_WELCOME_MSG}
- - - - - - - - - - - - - - -
{L_BUDDY_LIST}
{buddy_list.ONLINE_IMG}{buddy_list.BUDDY}{L_PM}{buddy_list.REMOVE_BUDDY}
-
- - - - - - - - - - - -
{L_UNREAD_PM} -
{pm.NEW_PM_IMG}{pm.PM_TITLE}{pm.PM_SENDER}{pm.DELETE_PM_IMG}
- + + + + + + + + + + + + + + + + +
{L_UCP_OPTIONS}
{ucp_subsection.L_TITLE} + + {ucp_subsection.L_TITLE} + +
 
 
+ + + + + + + + + + + + \ No newline at end of file diff --git a/phpBB/templates/subSilver/ucp_prefs.html b/phpBB/templates/subSilver/ucp_prefs.html index a3b77b11e2..66e2516528 100644 --- a/phpBB/templates/subSilver/ucp_prefs.html +++ b/phpBB/templates/subSilver/ucp_prefs.html @@ -5,7 +5,7 @@ -
{L_UCP}{L_UCP}
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
+ + + + +
{L_UCP_WELCOME}
{L_IMPORTANT_NEWS}
{topicrow.TOPIC_FOLDER_IMG}{topicrow.NEWEST_POST_IMG}{topicrow.ATTACH_ICON_IMG}{topicrow.TOPIC_TYPE}{topicrow.TOPIC_TITLE}
{topicrow.GOTO_PAGE}		{topicrow.LAST_POST_TIME}
{topicrow.LAST_POST_AUTHOR} {topicrow.LAST_POST_IMG}
{L_YOUR_DETAILS}
+ + + + + + + + +
{L_JOINED}: {JOINED}
{L_TOTAL_POSTS}: {POSTS}
[{POSTS_PCT} / {POSTS_DAY}]
{L_SEARCH_USER_POSTS}{POSTS}
 
{L_WATCHED_FORUMS}
{forumrow.FOLDER_IMG}{forumrow.FORUM_TITLE}{forumrow.LAST_POST_TIME}
{forumrow.LAST_POST_AUTHOR} {forumrow.LAST_POST_IMG}
{L_NO_WATCHED_FORUMS}
{L_WATCHED_TOPICS}
{topicrow.TOPIC_FOLDER_IMG}{topicrow.NEWEST_POST_IMG}{topicrow.ATTACH_ICON_IMG}{topicrow.TOPIC_TYPE}{topicrow.TOPIC_TITLE}
{topicrow.GOTO_PAGE}		{topicrow.LAST_POST_TIME}
{topicrow.LAST_POST_AUTHOR} {topicrow.LAST_POST_IMG}
{L_NO_WATCHED_TOPICS}
 
- + @@ -24,7 +24,8 @@
Options{L_UCP_OPTIONS}
 
+ +
@@ -37,7 +38,7 @@ - + - + - - - - - + - + - + - + + + + + @@ -101,7 +97,7 @@ - + - + - + - + + + + + diff --git a/phpBB/templates/subSilver/ucp_profile.html b/phpBB/templates/subSilver/ucp_profile.html index ade2418f38..93bed921e4 100644 --- a/phpBB/templates/subSilver/ucp_profile.html +++ b/phpBB/templates/subSilver/ucp_profile.html @@ -42,25 +42,25 @@ - + - + - + - + - + @@ -166,24 +166,24 @@ diff --git a/phpBB/ucp.php b/phpBB/ucp.php index d38c551a74..e412d1fbcd 100755 --- a/phpBB/ucp.php +++ b/phpBB/ucp.php @@ -23,13 +23,9 @@ // // * Registration // * Link to (additional?) registration conditions -// * Form based click through rather than links -// * Inform user of registration method i.e. if a valid email is required // * Admin defineable characters allowed in usernames? // * Admin forced revalidation of given user/s from ACP // * Simple registration (option or always?), i.e. username, email address, password -// * Tab based control panel -// * Modular/plug-in approach // * Opening tab: // * Last visit time // * Last active in @@ -37,20 +33,11 @@ // * Current Karma // * New PM counter // * Unread PM counter -// * Subscribed forum and topic lists + unsubscribe option, etc. -// * (Unread?) Global announcements? // * Link/s to MCP if applicable? // * Black and White lists // * Add buddy/ignored user // * Group buddies/ignored users? // * Mark posts/PM's of buddies different colour? -// * Preferences -// * Username -// * email address/es -// * password -// * Various flags -// * Profile -// * As required // * PM system // * See privmsg // * Avatars diff --git a/phpBB/ucp/ucp_main.php b/phpBB/ucp/ucp_main.php index 1dd4b2795a..b4d86758be 100644 --- a/phpBB/ucp/ucp_main.php +++ b/phpBB/ucp/ucp_main.php @@ -23,164 +23,326 @@ class ucp_main extends ucp { function main($id) { - global $config, $db, $user, $SID, $template, $phpEx; + global $config, $censors, $db, $user, $auth, $SID, $template, $phpEx; - $submode = ($_REQUEST['mode']) ? htmlspecialchars($_REQUEST['mode']) : 'personal'; + $submode = ($_REQUEST['mode']) ? htmlspecialchars($_REQUEST['mode']) : 'front'; // Setup internal subsection display - $submodules['PERSONAL'] = "i=$id&mode=personal"; - $submodules['VIEW'] = "i=$id&mode=view"; - $submodules['POST'] = "i=$id&mode=post"; - + $submodules['FRONT'] = "i=$id&mode=front"; + $submodules['WATCHED'] = "i=$id&mode=watched"; $this->subsection($submodules, $submode); unset($submodules); - switch($submode) + switch ($submode) { - case 'view': - break; + case 'front': - case 'post': - break; + if ($config['load_db_lastread']) + { + $sql = 'SELECT mark_time + FROM ' . FORUMS_TRACK_TABLE . ' + WHERE forum_id = 0 + AND user_id = ' . $user->data['user_id']; + $result = $db->sql_query($sql); - default: - break; - } + $track_data = $db->sql_fetchrow($result); + $db->sql_freeresult($result); + } + else + { + $tracking_topics = (isset($_COOKIE[$config['cookie_name'] . '_t'])) ? unserialize($_COOKIE[$config['cookie_name'] . '_t']) : array(); + $tracking_forums = (isset($_COOKIE[$config['cookie_name'] . '_f'])) ? unserialize($_COOKIE[$config['cookie_name'] . '_f']) : array(); + } + $i = 0; + $topic_type = $user->lang['VIEW_TOPIC_ANNOUNCEMENT']; + $folder = 'folder_announce'; + $folder_new = $folder . '_new'; - // Subscribed Topics - $sql = "SELECT tw.topic_id, t.topic_title, t.topic_last_post_time, t.poll_start, t.topic_replies, t.topic_type, t.forum_id - FROM " . TOPICS_TABLE . " t, " . TOPICS_WATCH_TABLE . " tw - WHERE t.topic_id = tw.topic_id - AND tw.user_id = " . $user->data['user_id'] . " - ORDER BY t.topic_last_post_time DESC"; - $result = $db->sql_query($sql); + $sql_tracking = (($config['load_db_lastread'] || $config['load_db_track']) && $user->data['user_id'] != ANONYMOUS) ? 'LEFT JOIN ' . TOPICS_TRACK_TABLE . ' tt ON (tt.topic_id = t.topic_id AND tt.user_id = ' . $user->data['user_id'] . ')' : ''; + $sql_select = (($config['load_db_lastread'] || $config['load_db_track']) && $user->data['user_id'] != ANONYMOUS) ? ', tt.mark_type, tt.mark_time' : ''; + $sql = "SELECT t.* $sql_select + FROM (" . TOPICS_TABLE . " t + $sql_tracking) + WHERE t.forum_id = 0 + AND t.topic_type = " . POST_ANNOUNCE . ' + ORDER BY t.topic_last_post_time DESC'; + $result = $db->sql_query_limit($sql, $config['topics_per_page']); - $topic_count = 0; - while ($row = $db->sql_fetchrow($result)) - { - $replies = $row['topic_replies']; - $topic_id = $row['topic_id']; - $forum_id = $row['forum_id']; - - switch ($row['topic_type']) - { - case POST_ANNOUNCE: - $topic_type = $user->lang['Topic_Announcement'] . ' '; - $folder = 'folder_announce'; - $folder_new = 'folder_announce_new'; - break; + while ($row = $db->sql_fetchrow($result)) + { + $forum_id = $row['forum_id']; + $topic_id = $row['topic_id']; - case POST_STICKY: - $topic_type = $user->lang['Topic_Sticky'] . ' '; - $folder = 'folder_sticky'; - $folder_new = 'folder_sticky_new'; - break; - - case ITEM_LOCKED: - $folder = 'folder_locked'; - $folder_new = 'folder_locked_new'; - break; - - default: - if ($replies >= intval($config['hot_threshold'])) + if ($row['topic_status'] == ITEM_LOCKED) { - $folder = 'folder_hot'; - $folder_new = 'folder_hot_new'; + $topic_type = $user->lang['VIEW_TOPIC_LOCKED']; + $folder = 'folder_locked'; + $folder_new = 'folder_locked_new'; + } + + $unread_topic = ($user->data['user_id'] != ANONYMOUS) ? true : false; + if ($user->data['user_id'] != ANONYMOUS) + { + $topic_check = (!$config['load_db_lastread']) ? $tracking_topics[$topic_id] : $row['mark_time']; + $forum_check = (!$config['load_db_lastread']) ? $tracking_forums[$forum_id] : $track_data['mark_time']; + + if ($topic_check > $row['topic_last_post_time'] || $forum_check > $row['topic_last_post_time']) + { + $unread_topic = false; + } + } + + $newest_post_img = ($unread_topic) ? "" . $user->img('icon_post_newest', 'VIEW_NEWEST_POST') . ' ' : ''; + $folder_img = ($unread_topic) ? $folder_new : $folder; + $folder_alt = ($unread_topic) ? 'NEW_POSTS' : (($row['topic_status'] == ITEM_LOCKED) ? 'TOPIC_LOCKED' : 'NO_NEW_POSTS'); + + // Posted image? + if (!empty($row['mark_type'])) + { + $folder_img .= '_posted'; + } + + // Goto message generation + $replies = ($auth->acl_get('m_approve')) ? $row['topic_replies_real'] : $row['topic_replies']; + + if (($replies + 1) > intval($config['posts_per_page'])) + { + $total_pages = ceil(($replies + 1) / intval($config['posts_per_page'])); + $goto_page = ' [ ' . $user->img('icon_post', 'GOTO_PAGE') . $user->lang['GOTO_PAGE'] . ': '; + + $times = 1; + for($j = 0; $j < $replies + 1; $j += intval($config['posts_per_page'])) + { + $goto_page .= "$times"; + if ($times == 1 && $total_pages > 4) + { + $goto_page .= ' ... '; + $times = $total_pages - 3; + $j += ($total_pages - 4) * intval($config['posts_per_page']); + } + else if ($times < $total_pages) + { + $goto_page .= ', '; + } + $times++; + } + $goto_page .= ' ] '; } else { - $folder = 'folder'; - $folder_new = 'folder_new'; + $goto_page = ''; } - break; - } - $unread_topic = false; - if ($user->data['user_id'] && $row['topic_last_post_time'] > $user->data['session_last_visit']) - { - $unread_topic = true; - } + $view_topic_url = "viewtopic.$phpEx$SID&f=$forum_id&t=$topic_id"; - $newest_post_img = ($unread_topic) ? '' . $user->img('goto_post_newest', 'View_newest_post') . ' ' : ''; - $folder_img = ($unread_topic) ? $folder_new : $folder; - $folder_alt = ($unread_topic) ? 'New_posts' : (($row['topic_status'] == ITEM_LOCKED) ? 'Topic_locked' : 'No_new_posts'); + $last_post_img = "' . $user->img('icon_post_latest', 'VIEW_LATEST_POST') . ''; - $view_topic_url = 'viewtopic.' . $phpEx . $SID . '&f=' . $forum_id . '&t=' . $topic_id; + $last_post_author = ($row['topic_last_poster_id'] == ANONYMOUS) ? (($row['topic_last_poster_name'] != '') ? $row['topic_last_poster_name'] . ' ' : $user->lang['GUEST'] . ' ') : "' . $row['topic_last_poster_name'] . ''; - $template->assign_block_vars('subscribed_topics', array( - 'TOPIC_FOLDER_IMG' => $user->img($folder_img, $folder_alt), - 'NEWEST_POST_IMG' => $newest_post_img, + $template->assign_block_vars('topicrow', array( + 'FORUM_ID' => $forum_id, + 'TOPIC_ID' => $topic_id, + 'LAST_POST_TIME' => $user->format_date($row['topic_last_post_time']), + 'LAST_POST_AUTHOR' => $last_post_author, + 'GOTO_PAGE' => $goto_page, + 'TOPIC_TITLE' => (!empty($censors)) ? preg_replace($censors['match'], $censors['replace'], $row['topic_title']) : $row['topic_title'], + 'TOPIC_TYPE' => $topic_type, - 'TOPIC_TITLE' => (!empty($censors)) ? preg_replace($censors['match'], $censors['replace'], $row['topic_title']) : $row['topic_title'], - - 'U_TOPIC' => $view_topic_url) - ); + 'LAST_POST_IMG' => $last_post_img, + 'NEWEST_POST_IMG' => $newest_post_img, + 'TOPIC_FOLDER_IMG' => $user->img($folder_img, $folder_alt), + 'ATTACH_ICON_IMG' => ($auth->acl_get('f_download', $forum_id) && $row['topic_attachment']) ? $user->img('icon_attach', '') : '', + + 'S_ROW_COUNT' => $i, + 'S_USER_POSTED' => (!empty($row['mark_type'])) ? true : false, + + 'U_VIEW_TOPIC' => $view_topic_url) + ); + + $i++; + } + $db->sql_freeresult($result); + + + + break; + + case 'watched': + + // Subscribed Topics + if ($config['load_db_lastread']) + { + $sql = 'SELECT mark_time + FROM ' . FORUMS_TRACK_TABLE . ' + WHERE forum_id = 0 + AND user_id = ' . $user->data['user_id']; + $result = $db->sql_query($sql); + + $track_data = $db->sql_fetchrow($result); + $db->sql_freeresult($result); + } + else + { + $tracking_topics = (isset($_COOKIE[$config['cookie_name'] . '_t'])) ? unserialize($_COOKIE[$config['cookie_name'] . '_t']) : array(); + $tracking_forums = (isset($_COOKIE[$config['cookie_name'] . '_f'])) ? unserialize($_COOKIE[$config['cookie_name'] . '_f']) : array(); + } + + + $sql_tracking = (($config['load_db_lastread'] || $config['load_db_track']) && $user->data['user_id'] != ANONYMOUS) ? 'LEFT JOIN ' . TOPICS_TRACK_TABLE . ' tt ON (tt.topic_id = t.topic_id AND tt.user_id = ' . $user->data['user_id'] . ')' : ''; + $sql_select = (($config['load_db_lastread'] || $config['load_db_track']) && $user->data['user_id'] != ANONYMOUS) ? ', tt.mark_type, tt.mark_time' : ''; + $sql = "SELECT t.* $sql_select + FROM (" . TOPICS_TABLE . " t + $sql_tracking), " . TOPICS_WATCH_TABLE . ' tw + WHERE tw.user_id = ' . $user->data['user_id'] . ' + AND t.topic_id = tw.topic_id + ORDER BY t.topic_last_post_time DESC'; + $result = $db->sql_query_limit($sql, $config['topics_per_page']); + + $i = 0; + while ($row = $db->sql_fetchrow($result)) + { + $forum_id = $row['forum_id']; + $topic_id = $row['topic_id']; + + // Goto message generation + $replies = ($auth->acl_get('m_approve')) ? $row['topic_replies_real'] : $row['topic_replies']; + + + $topic_type = ''; + switch ($row['topic_type']) + { + case POST_ANNOUNCE: + $topic_type = $user->lang['VIEW_TOPIC_ANNOUNCEMENT']; + $folder = 'folder_announce'; + $folder_new = 'folder_announce_new'; + break; + + case POST_STICKY: + $topic_type = $user->lang['VIEW_TOPIC_STICKY']; + $folder = 'folder_sticky'; + $folder_new = 'folder_sticky_new'; + break; + + default: + if ($replies >= intval($config['hot_threshold'])) + { + $folder = 'folder_hot'; + $folder_new = 'folder_hot_new'; + } + else + { + $folder = 'folder'; + $folder_new = 'folder_new'; + } + break; + } + + if ($row['topic_status'] == ITEM_LOCKED) + { + $topic_type = $user->lang['VIEW_TOPIC_LOCKED']; + $folder = 'folder_locked'; + $folder_new = 'folder_locked_new'; + } + + $unread_topic = ($user->data['user_id'] != ANONYMOUS) ? true : false; + if ($user->data['user_id'] != ANONYMOUS) + { + $topic_check = (!$config['load_db_lastread']) ? $tracking_topics[$topic_id] : $row['mark_time']; + $forum_check = (!$config['load_db_lastread']) ? $tracking_forums[$forum_id] : $track_data['mark_time']; + + if ($topic_check > $row['topic_last_post_time'] || $forum_check > $row['topic_last_post_time']) + { + $unread_topic = false; + } + } + + $newest_post_img = ($unread_topic) ? "" . $user->img('icon_post_newest', 'VIEW_NEWEST_POST') . ' ' : ''; + $folder_img = ($unread_topic) ? $folder_new : $folder; + $folder_alt = ($unread_topic) ? 'NEW_POSTS' : (($row['topic_status'] == ITEM_LOCKED) ? 'TOPIC_LOCKED' : 'NO_NEW_POSTS'); + + // Posted image? + if (!empty($row['mark_type'])) + { + $folder_img .= '_posted'; + } + + if (($replies + 1) > intval($config['posts_per_page'])) + { + $total_pages = ceil(($replies + 1) / intval($config['posts_per_page'])); + $goto_page = ' [ ' . $user->img('icon_post', 'GOTO_PAGE') . $user->lang['GOTO_PAGE'] . ': '; + + $times = 1; + for($j = 0; $j < $replies + 1; $j += intval($config['posts_per_page'])) + { + $goto_page .= "$times"; + if ($times == 1 && $total_pages > 4) + { + $goto_page .= ' ... '; + $times = $total_pages - 3; + $j += ($total_pages - 4) * intval($config['posts_per_page']); + } + else if ($times < $total_pages) + { + $goto_page .= ', '; + } + $times++; + } + $goto_page .= ' ] '; + } + else + { + $goto_page = ''; + } + + $view_topic_url = "viewtopic.$phpEx$SID&f=$forum_id&t=$topic_id"; + + $last_post_img = "' . $user->img('icon_post_latest', 'VIEW_LATEST_POST') . ''; + + $last_post_author = ($row['topic_last_poster_id'] == ANONYMOUS) ? (($row['topic_last_poster_name'] != '') ? $row['topic_last_poster_name'] . ' ' : $user->lang['GUEST'] . ' ') : "' . $row['topic_last_poster_name'] . ''; + + $template->assign_block_vars('topicrow', array( + 'FORUM_ID' => $forum_id, + 'TOPIC_ID' => $topic_id, + 'LAST_POST_TIME' => $user->format_date($row['topic_last_post_time']), + 'LAST_POST_AUTHOR' => $last_post_author, + 'GOTO_PAGE' => $goto_page, + 'TOPIC_TITLE' => (!empty($censors)) ? preg_replace($censors['match'], $censors['replace'], $row['topic_title']) : $row['topic_title'], + 'TOPIC_TYPE' => $topic_type, + + 'LAST_POST_IMG' => $last_post_img, + 'NEWEST_POST_IMG' => $newest_post_img, + 'TOPIC_FOLDER_IMG' => $user->img($folder_img, $folder_alt), + 'ATTACH_ICON_IMG' => ($auth->acl_get('f_download', $forum_id) && $row['topic_attachment']) ? $user->img('icon_attach', '') : '', + + 'S_ROW_COUNT' => $i, + 'S_USER_POSTED' => (!empty($row['mark_type'])) ? true : false, + + 'U_VIEW_TOPIC' => $view_topic_url) + ); + + $i++; + } + $db->sql_freeresult($result); + + + // Subscribed Forums + $sql = "SELECT f.forum_id, f.forum_last_post_time, f.forum_last_post_id, f.left_id, f.right_id, f.forum_status, f.forum_name, f.forum_desc + FROM " . FORUMS_TABLE . " f, " . FORUMS_WATCH_TABLE . " fw + WHERE f.forum_id = fw.forum_id + AND fw.user_id = " . $user->data['user_id'] . " + ORDER BY f.forum_last_post_time DESC"; + $result = $db->sql_query($sql); + + while ($row = $db->sql_fetchrow($result)) + { + + } + $db->sql_freeresult($result); + + break; } - $db->sql_freeresult($result); - // End Subscribed Topics - - - // Subscribed Forums - $sql = "SELECT f.forum_id, f.forum_last_post_time, f.forum_last_post_id, f.left_id, f.right_id, f.forum_status, f.forum_name, f.forum_desc - FROM " . FORUMS_TABLE . " f, " . FORUMS_WATCH_TABLE . " fw - WHERE f.forum_id = fw.forum_id - AND fw.user_id = " . $user->data['user_id'] . " - ORDER BY f.forum_last_post_time DESC"; - $result = $db->sql_query($sql); - - while ($row = $db->sql_fetchrow($result)) - { - $forum_id = $row['forum_id']; - - $unread_topics = ($user->data['user_id'] && $row['forum_last_post_time'] > $user->data['user_lastvisit']) ? TRUE : FALSE; - - $folder_image = ($unread_topics) ? 'forum_new' : 'forum'; - $folder_alt = ($unread_topics) ? 'New_posts' : 'No_new_posts'; - - if ($row['left_id'] + 1 < $row['right_id']) - { - $folder_image = ($unread_topics) ? 'sub_forum_new' : 'sub_forum'; - $folder_alt = ($unread_topics) ? 'New_posts' : 'No_new_posts'; - } - elseif ($row['forum_status'] == ITEM_LOCKED) - { - $folder_image = 'forum_locked'; - $folder_alt = 'Forum_locked'; - } - else - { - $folder_image = ($unread_topics) ? 'forum_new' : 'forum'; - $folder_alt = ($unread_topics) ? 'New_posts' : 'No_new_posts'; - } - - $last_post = '' . $user->img('goto_post_latest', 'View_latest_post') . ''; - - - $template->assign_block_vars('subscribed_forums', array( - 'FORUM_FOLDER_IMG' => $user->img($folder_image, $folder_alt), - 'NEWEST_FORUM_POST_IMG' => $last_post, - - 'FORUM_NAME' => $row['forum_name'], - - 'U_FORUM' => 'viewforum.' . $phpEx . $SID . '&f=' . $row['forum_id']) - ); - } - $db->sql_freeresult($result); - // End Subscribed forums - - - // Buddy List - - // End Buddy List - - - // Private Messages - - // End Private Messages - - $template->assign_vars(array( diff --git a/phpBB/ucp/ucp_profile.php b/phpBB/ucp/ucp_profile.php index a37fc6a8a3..b1513e0e7f 100644 --- a/phpBB/ucp/ucp_profile.php +++ b/phpBB/ucp/ucp_profile.php @@ -29,7 +29,7 @@ class ucp_profile extends ucp $submode = ($_REQUEST['mode']) ? htmlspecialchars($_REQUEST['mode']) : 'reg_details'; $submodules['REG_DETAILS'] = "i=$id&mode=reg_details"; - $submodules['PROFILE'] = "i=$id&mode=profile"; + $submodules['PROFILE_INFO'] = "i=$id&mode=profile_info"; $submodules['SIGNATURE'] = "i=$id&mode=signature"; $submodules['AVATAR'] = "i=$id&mode=avatar"; @@ -50,7 +50,7 @@ class ucp_profile extends ucp ); break; - case 'profile': + case 'profile_info': list($day, $month, $year) = explode('-', $user->data['user_birthday']); diff --git a/phpBB/viewforum.php b/phpBB/viewforum.php index ff5eb34021..cf60bb8d4b 100644 --- a/phpBB/viewforum.php +++ b/phpBB/viewforum.php @@ -342,7 +342,11 @@ if ($forum_data['forum_type'] == FORUM_POST) foreach ($row_ary as $row) { $topic_id = $row['topic_id']; - $replies = ($auth->acl_get('m_approve', $forum_id)) ? $row['topic_replies_real'] : $row['topic_replies']; + + + // How many replies? hhmmm 1? 2? let's find out + $replies = ($auth->acl_get('m_approve')) ? $row['topic_replies_real'] : $row['topic_replies']; + // Type and folder $topic_type = ''; @@ -426,8 +430,6 @@ if ($forum_data['forum_type'] == FORUM_POST) // Goto message generation - $replies = ($auth->acl_get('m_approve')) ? $row['topic_replies_real'] : $row['topic_replies']; - if (($replies + 1) > intval($config['posts_per_page'])) { $total_pages = ceil(($replies + 1) / intval($config['posts_per_page'])); diff --git a/phpBB/viewtopic.php b/phpBB/viewtopic.php index 1b28758072..a480ca961f 100644 --- a/phpBB/viewtopic.php +++ b/phpBB/viewtopic.php @@ -36,27 +36,20 @@ $topic_id = (isset($_GET['t'])) ? max(intval($_GET['t']), 0) : 0; $post_id = (isset($_GET['p'])) ? max(intval($_GET['p']), 0) : 0; $start = (isset($_GET['start'])) ? max(intval($_GET['start']), 0) : 0; -// Do we need to check for specific allowed keys here? So long as -// parameters are not directly used in SQL I'm tempted to say -// if someone wishes to screw their view up by entering unknown data -// good luck to them :D - -// If, for some reason, the SQL query would not fail and $sort vars were -// displayed in $pagination_url they could be used for XSS -- Ashe $sort_days = (!empty($_REQUEST['st'])) ? max(intval($_REQUEST['st']), 0) : 0; $sort_key = (!empty($_REQUEST['sk'])) ? htmlspecialchars($_REQUEST['sk']) : 't'; $sort_dir = (!empty($_REQUEST['sd'])) ? htmlspecialchars($_REQUEST['sd']) : 'a'; // Do we have a topic or post id? -if (empty($topic_id) && empty($post_id)) +if (!$topic_id && !$post_id) { trigger_error('NO_TOPIC'); } // Find topic id if user requested a newer or older topic -if (isset($_GET['view']) && empty($post_id)) +if (isset($_GET['view']) && !$post_id) { if ($_GET['view'] == 'unread') { @@ -433,7 +426,6 @@ $template->assign_vars(array( 'REPORTED_IMG' => $user->img('icon_reported', $user->lang['POST_BEEN_REPORTED']), 'UNAPPROVED_IMG' => $user->img('icon_unapproved', $user->lang['POST_NOT_BEEN_APPROVED']), - 'S_TOPIC_LINK' => 't', 'S_SELECT_SORT_DIR' => $s_sort_dir, 'S_SELECT_SORT_KEY' => $s_sort_key, 'S_SELECT_SORT_DAYS' => $s_limit_days,
{L_TITLE}
{L_PUBLIC_VIEW_EMAIL}:{L_SHOW_EMAIL}: {L_YES}   @@ -45,7 +46,7 @@ {L_NO}
{L_HIDE_USER}:{L_HIDE_ONLINE}: {L_YES}   @@ -53,16 +54,7 @@ {L_NO}
{L_NOTIFY_ON_REPLY}:
- {L_NOTIFY_ON_REPLY_EXPLAIN}		 - - {L_YES}   - - {L_NO}
{L_NOTIFY_ON_PRIVMSG}:{L_NOTIFY_ON_PM}: {L_YES}   @@ -70,7 +62,7 @@ {L_NO}
{L_POPUP_ON_PRIVMSG}:
{L_POPUP_ON_PRIVMSG_EXPLAIN}		{L_POPUP_ON_PM}: {L_YES}   @@ -86,12 +78,16 @@
{L_TIMEZONE}:{L_BOARD_TIMEZONE}:
{L_DATE_FORMAT}:
- {L_DATE_FORMAT_EXPLAIN}		{L_BOARD_DST}: {L_YES}   {L_NO}
{L_BOARD_DATE_FORMAT}:
+ {L_BOARD_DATE_FORMAT_EXPLAIN}
{L_ALWAYS_ADD_SIGNATURE}:{L_DEFAULT_ADD_SIG}: {L_YES}   @@ -109,7 +105,7 @@ {L_NO}
{L_ALWAYS_ALLOW_BBCODE}:{L_DEFAULT_BBCODE}: {L_YES}   @@ -117,7 +113,7 @@ {L_NO}
{L_ALWAYS_ALLOW_HTML}:{L_DEFAULT_HTML}: {L_YES}   @@ -125,13 +121,21 @@ {L_NO}
{L_ALWAYS_ALLOW_SMILIES}:{L_DEFAULT_SMILE}: {L_YES}   {L_NO}
{L_DEFAULT_NOTIFY}: + + {L_YES}   + + {L_NO}
{L_EMAIL_ADDRESS}: {EMAIL}{EMAIL}
{L_NEW_PASSWORD}:
{L_NEW_PASSWORD_EXPLAIN}
{L_CONFIRM_PASSWORD}:
{L_CONFIRM_PASSWORD_EXPLAIN}
{L_CURRENT_PASSWORD}:
{L_CURRENT_PASSWORD_EXPLAIN}
{L_PROFILE_INFO_NOTICE}
- + - + - + - +
{L_DISABLE_HTML}
{L_DISABLE_BBCODE}
{L_DISABLE_SMILIES}
{L_DISABLE_MAGIC_URL}