makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10270] Replaced find by tag names with class names in the js.

Browse source 
What it was before (selecting by tag name) could have caused some
problems for style authors.

PHPBB3-10270
This commit is contained in:
Callum Macrae 2011-10-15 16:21:40 +01:00 • committed by Igor Wiedler
parent 5b2352613e
commit 3166cbb33d
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
phpBB/adm/style/overall_footer.html
View file

@ -25,11 +25,11 @@
<div id="phpbb_alert" class="phpbb_alert"> <div id="phpbb_alert" class="phpbb_alert">
<a href="#"><img src="{T_THEME_PATH}/images/alert_close.png" class="alert_close" /></a> <a href="#"><img src="{T_THEME_PATH}/images/alert_close.png" class="alert_close" /></a>
<h3></h3><p></p> <h3 class="alert_title"></h3><p class="alert_text"></p>
</div> </div>
<div id="phpbb_confirm" class="phpbb_alert"> <div id="phpbb_confirm" class="phpbb_alert">
<a href="#"><img src="{T_THEME_PATH}/images/alert_close.png" class="alert_close" /></a> <a href="#"><img src="{T_THEME_PATH}/images/alert_close.png" class="alert_close" /></a>
<p></p> <p class="alert_text"></p>
<input type="button" class="button1" value="{L_YES}" />&nbsp; <input type="button" class="button1" value="{L_YES}" />&nbsp;
<input type="button" class="button2" value="{L_NO}" /> <input type="button" class="button2" value="{L_NO}" />
</div> </div>

6
phpBB/assets/javascript/core.js
View file

@ -48,8 +48,8 @@ phpbb.loading_alert = function() {
*/ */
phpbb.alert = function(title, msg, fadedark) { phpbb.alert = function(title, msg, fadedark) {
var div = $('#phpbb_alert'); var div = $('#phpbb_alert');
div.find('h3').html(title); div.find('.alert_title').html(title);
div.find('p').html(msg); div.find('.alert_text').html(msg);
div.bind('click', function(e) { div.bind('click', function(e) {
e.stopPropagation(); e.stopPropagation();
@ -110,7 +110,7 @@ phpbb.alert = function(title, msg, fadedark) {
*/ */
phpbb.confirm = function(msg, callback, fadedark) { phpbb.confirm = function(msg, callback, fadedark) {
var div = $('#phpbb_confirm'); var div = $('#phpbb_confirm');
div.find('p').html(msg); div.find('.alert_text').html(msg);
div.bind('click', function(e) { div.bind('click', function(e) {
e.stopPropagation(); e.stopPropagation();

4
phpBB/styles/prosilver/template/overall_footer.html
View file

@ -32,11 +32,11 @@
<div id="phpbb_alert" class="phpbb_alert"> <div id="phpbb_alert" class="phpbb_alert">
<a href="#"><img src="{T_THEME_PATH}/images/alert_close.png" class="alert_close" /></a> <a href="#"><img src="{T_THEME_PATH}/images/alert_close.png" class="alert_close" /></a>
<h3></h3><p></p> <h3 class="alert_title"></h3><p class="alert_text"></p>
</div> </div>
<div id="phpbb_confirm" class="phpbb_alert"> <div id="phpbb_confirm" class="phpbb_alert">
<a href="#"><img src="{T_THEME_PATH}/images/alert_close.png" class="alert_close" /></a> <a href="#"><img src="{T_THEME_PATH}/images/alert_close.png" class="alert_close" /></a>
<p></p> <p class="alert_text"></p>
<input type="button" class="button1" value="{L_YES}" />&nbsp; <input type="button" class="button1" value="{L_YES}" />&nbsp;
<input type="button" class="button2" value="{L_NO}" /> <input type="button" class="button2" value="{L_NO}" />
</div> </div>