makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-11 05:48:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/17333] Optimize loading web push data only when needed

Browse source 
PHPBB-17333

Signed-off-by: Matt Friedman <maf675@gmail.com>
This commit is contained in:
Matt Friedman 2024-06-05 18:47:57 -07:00
parent 73e0412c88
commit 36527a97b8
No known key found for this signature in database
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
phpBB/includes/functions.php
View file

@ -3873,15 +3873,18 @@ function page_header($page_title = '', $display_online_list = false, $item_id =
$template->assign_block_vars('notifications', $notification->prepare_for_display()); $template->assign_block_vars('notifications', $notification->prepare_for_display());
} }
// Assign notification web push template data (if not done already by ucp_notifications) // Assign web push template vars globally (if not done already by ucp_notifications) for the dropdown subscribe button
if ($config['webpush_dropdown_subscribe'] && $template->retrieve_var('NOTIFICATIONS_WEBPUSH_ENABLE') === null) if ($config['webpush_enable']
&& $config['webpush_dropdown_subscribe']
&& $template->retrieve_var('NOTIFICATIONS_WEBPUSH_ENABLE') === null)
{ {
$methods = $phpbb_notifications->get_subscription_methods(); $methods = $phpbb_notifications->get_subscription_methods();
if (isset($methods['notification.method.webpush'])) $webpush = $methods['notification.method.webpush'] ?? null;
{
$form_helper = $phpbb_container->get('form_helper');
$template_ary = $methods['notification.method.webpush']['method']->get_ucp_template_data($controller_helper, $form_helper); if ($webpush)
{
$formHelper = $phpbb_container->get('form_helper');
$template_ary = $webpush['method']->get_ucp_template_data($controller_helper, $formHelper);
$template->assign_vars($template_ary); $template->assign_vars($template_ary);
} }
} }