Merge branch 'ticket/10839-olympus' into ticket/10839

* ticket/10839-olympus:
  [ticket/10839] Fix note about running slow tests and build task
  [ticket/10839] Removing phpunit.xml.all
  [ticket/10839] Always run functional tests by default

Conflicts:
	phpunit.xml.dist

build/build.xml

@@ -67,7 +67,6 @@
 		<exec dir="."
 			command="phpBB/vendor/bin/phpunit
 			--log-junit build/logs/phpunit.xml
-			--configuration phpunit.xml.all
 			--group slow
 			--coverage-clover build/logs/clover-slow.xml
 			--coverage-html build/coverage-slow"

phpunit.xml.all

@@ -1,36 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-
-<phpunit backupGlobals="true"
-         backupStaticAttributes="true"
-         colors="true"
-         convertErrorsToExceptions="true"
-         convertNoticesToExceptions="true"
-         convertWarningsToExceptions="true"
-         processIsolation="false"
-         stopOnFailure="false"
-         syntaxCheck="false"
-         bootstrap="tests/bootstrap.php"
->
-    <testsuites>
-        <testsuite name="phpBB Test Suite">
-            <directory suffix="_test.php">./tests</directory>
-            <exclude>./tests/lint_test.php</exclude>
-        </testsuite>
-        <testsuite name="phpBB Lint Test">
-            <file>./tests/lint_test.php</file>
-        </testsuite>
-    </testsuites>
-
-    <filter>
-        <blacklist>
-            <directory>./tests</directory>
-        </blacklist>
-        <whitelist>
-            <directory suffix=".php">./phpBB/includes/</directory>
-            <directory suffix=".php">./phpBB/phpbb/</directory>
-            <exclude>
-                <directory suffix=".php">./phpBB/includes/captcha/</directory>
-            </exclude>
-        </whitelist>
-    </filter>
-</phpunit>

phpunit.xml.dist

@@ -17,6 +17,9 @@
             <exclude>./tests/functional</exclude>
             <exclude>./tests/lint_test.php</exclude>
         </testsuite>
+        <testsuite name="phpBB Functional Tests">
+            <directory suffix="_test.php" phpVersion="5.3.0" phpVersionOperator=">=">./tests/functional</directory>
+        </testsuite>
         <testsuite name="phpBB Lint Test">
             <file>./tests/lint_test.php</file>
         </testsuite>
@@ -24,7 +27,6 @@
 
     <groups>
         <exclude>
-            <group>functional</group>
             <group>slow</group>
         </exclude>
     </groups>

phpunit.xml.functional

@@ -1,43 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-
-<phpunit backupGlobals="true"
-         backupStaticAttributes="true"
-         colors="true"
-         convertErrorsToExceptions="true"
-         convertNoticesToExceptions="true"
-         convertWarningsToExceptions="true"
-         processIsolation="false"
-         stopOnFailure="false"
-         syntaxCheck="false"
-         bootstrap="tests/bootstrap.php"
->
-    <testsuites>
-        <testsuite name="phpBB Test Suite">
-            <directory suffix="_test.php">./tests</directory>
-            <exclude>./tests/functional</exclude>
-            <exclude>./tests/lint_test.php</exclude>
-        </testsuite>
-        <testsuite name="phpBB Lint Test">
-            <file>./tests/lint_test.php</file>
-        </testsuite>
-    </testsuites>
-
-    <groups>
-        <include>
-            <group>functional</group>
-        </include>
-    </groups>
-
-    <filter>
-        <blacklist>
-            <directory>./tests</directory>
-        </blacklist>
-        <whitelist>
-            <directory suffix=".php">./phpBB/includes/</directory>
-            <directory suffix=".php">./phpBB/phpbb/</directory>
-            <exclude>
-                <directory suffix=".php">./phpBB/includes/captcha/</directory>
-            </exclude>
-        </whitelist>
-    </filter>
-</phpunit>

tests/RUNNING_TESTS.md

@@ -128,12 +128,16 @@ Slow tests
 --------------
 
 Certain tests, such as the UTF-8 normalizer or the DNS tests tend to be slow.
-Thus these tests are in the `slow` group, which is excluded by default. You can
+Thus these tests are in the `slow` group, which is excluded by default. If you
-enable slow tests by copying the phpunit.xml.all file to phpunit.xml. If you
 only want the slow tests, run:
 
     $ phpBB/vendor/bin/phpunit --group slow
 
+If you want all tests, run:
+
+    $ phpBB/vendor/bin/phpunit --group __nogroup__,functional,slow
+
+
 Functional tests
 -----------------
 
@@ -154,10 +158,10 @@ on which to run tests.
 
     $phpbb_functional_url = 'http://localhost/phpBB3/';
 
-To then run the tests, you run PHPUnit, but use the phpunit.xml.functional
+Functional tests are automatically run, if '$phpbb_functional_url' is configured.
-config file instead of the default one. Specify this through the "-c" option:
+If you only want the functional tests, run:
 
-    $ phpBB/vendor/bin/phpunit -c phpunit.xml.functional
+    $ phpBB/vendor/bin/phpunit --group functional
 
 This will change your board's config.php file, but it makes a backup at
 config_dev.php, so you can restore it after the test run is complete.