Fixed various errors, added issets, removed unneeded sql error messages

git-svn-id: file:///svn/phpbb/trunk@275 89ea8834-ac86-4346-8a33-228a782c2dd0
This commit is contained in:
Paul S. Owen 2001-05-12 11:43:48 +00:00
parent 7da5561d24
commit 3f4ea178d6

View file

@ -1,6 +1,6 @@
<?php <?php
/*************************************************************************** /***************************************************************************
* common.php * memberlist.php
* ------------------- * -------------------
* begin : Friday, May 11, 2001 * begin : Friday, May 11, 2001
* copyright : (C) 2001 The phpBB Group * copyright : (C) 2001 The phpBB Group
@ -35,33 +35,55 @@ init_userprefs($userdata);
include('includes/page_header.'.$phpEx); include('includes/page_header.'.$phpEx);
if(!$start) if(!isset($HTTP_GET_VARS['start']))
{ {
$start = 0; $start = 0;
} }
switch($mode) if(isset($HTTP_GET_VARS['mode']))
{ {
case 'top10': switch($mode)
{
case 'topten':
$sql = "SELECT username, user_id, user_viewemail, user_posts, user_regdate, user_from, user_website, user_email $sql = "SELECT username, user_id, user_viewemail, user_posts, user_regdate, user_from, user_website, user_email
FROM ".USERS_TABLE." WHERE user_id != ".ANONYMOUS." AND user_level != ".DELETED." ORDER BY user_posts ASC LIMIT 10"; FROM ".USERS_TABLE."
WHERE user_id != ".ANONYMOUS."
AND user_level != ".DELETED."
ORDER BY user_posts DESC
LIMIT 10";
break; break;
case 'alpha': case 'alpha':
$sql = "SELECT username, user_id, user_viewemail, user_posts, user_regdate, user_from, user_website, user_email $sql = "SELECT username, user_id, user_viewemail, user_posts, user_regdate, user_from, user_website, user_email
FROM ".USERS_TABLE." WHERE user_id != ".ANONYMOUS." AND user_level != ".DELETED." ORDER BY username ASC LIMIT $start, ".$board_config['topics_per_page']; FROM ".USERS_TABLE."
WHERE user_id != ".ANONYMOUS."
AND user_level != ".DELETED."
ORDER BY username ASC
LIMIT $start, ".$board_config['topics_per_page'];
break; break;
default: default:
$sql = "SELECT username, user_id, user_viewemail, user_posts, user_regdate, user_from, user_website, user_email $sql = "SELECT username, user_id, user_viewemail, user_posts, user_regdate, user_from, user_website, user_email
FROM ".USERS_TABLE." WHERE user_id != ".ANONYMOUS." AND user_level != ".DELETED." ORDER BY user_id ASC LIMIT $start, ".$board_config['topics_per_page']; FROM ".USERS_TABLE."
WHERE user_id != ".ANONYMOUS."
AND user_level != ".DELETED."
ORDER BY user_id ASC
LIMIT $start, ".$board_config['topics_per_page'];
break; break;
}
}
else
{
$sql = "SELECT username, user_id, user_viewemail, user_posts, user_regdate, user_from, user_website, user_email
FROM ".USERS_TABLE."
WHERE user_id != ".ANONYMOUS."
AND user_level != ".DELETED."
ORDER BY user_id ASC
LIMIT $start, ".$board_config['topics_per_page'];
} }
if(!$result = $db->sql_query($sql)) if(!$result = $db->sql_query($sql))
{ {
if(DEBUG) if(DEBUG)
{ {
$error = $db->sql_error(); error_die(SQL_QUERY, "Error getting memberlist.", __LINE__, __FILE__);
error_die(SQL_QUERY, "Error getting memberlist.<br>Reason: ".$error['message']."<br>Query: $sql.", __LINE__, __FILE__);
} }
else else
{ {
@ -70,8 +92,10 @@ if(!$result = $db->sql_query($sql))
} }
if(($selected_members = $db->sql_numrows($result)) > 0) if(($selected_members = $db->sql_numrows($result)) > 0)
{ {
$template->set_filenames(array("body" => "memberlist_body.tpl")); $template->set_filenames(array(
$template->assign_vars(array("U_VIEW_TOP10" => append_sid("memberlist.$phpEx?mode=top10"), "body" => "memberlist_body.tpl"));
$template->assign_vars(array(
"U_VIEW_TOP10" => append_sid("memberlist.$phpEx?mode=topten"),
"U_SORTALPHA" => append_sid("memberlist.$phpEx?mode=alpha"), "U_SORTALPHA" => append_sid("memberlist.$phpEx?mode=alpha"),
"L_VIEW_TOP10" => $l_top10, "L_VIEW_TOP10" => $l_top10,
"L_SORTALPHA" => $l_alpha, "L_SORTALPHA" => $l_alpha,
@ -81,7 +105,7 @@ if(($selected_members = $db->sql_numrows($result)) > 0)
$members = $db->sql_fetchrowset($result); $members = $db->sql_fetchrowset($result);
for($x = $start; $x < $selected_members; $x++) for($x = 0; $x < $selected_members; $x++)
{ {
unset($email); unset($email);
$username = stripslashes($members[$x]['username']); $username = stripslashes($members[$x]['username']);
@ -129,15 +153,17 @@ if(($selected_members = $db->sql_numrows($result)) > 0)
"WEBSITE" => $url)); "WEBSITE" => $url));
} }
if($mode != "top10") if($mode != "topten")
{ {
$sql = "SELECT count(*) AS total FROM ".USERS_TABLE." WHERE user_id != ".ANONYMOUS." AND user_level != ".DELETED; $sql = "SELECT count(*) AS total
FROM ".USERS_TABLE."
WHERE user_id != ".ANONYMOUS."
AND user_level != ".DELETED;
if(!$count_result = $db->sql_query($sql)) if(!$count_result = $db->sql_query($sql))
{ {
if(DEBUG) if(DEBUG)
{ {
$error = $db->sql_error(); error_die(SQL_QUERY, "Error getting total users.", __LINE__, __FILE__);
error_die(SQL_QUERY, "Error getting total users<br>Reason: ".$error['message']."<br>Query: $sql", __LINE__, __FILE__);
} }
else else
{ {
@ -146,16 +172,17 @@ if(($selected_members = $db->sql_numrows($result)) > 0)
} }
else else
{ {
$total = $db->sql_fetchrowset($count_result); $total = $db->sql_fetchrow($count_result);
$total_members = $total[0]['total']; $total_members = $total['total'];
$pagination = generate_pagination("memberlist.$phpEx?mode=$mode", $total_members, $board_config['topics_per_page'], $start, TRUE)."&nbsp;"; $pagination = generate_pagination("memberlist.$phpEx?mode=$mode", $total_members, $board_config['topics_per_page'], $start)."&nbsp;";
} }
} }
else else
{ {
$pagination = "&nbsp;"; $pagination = "&nbsp;";
} }
$template->assign_vars(array("PAGINATION" => $pagination)); $template->assign_vars(array(
"PAGINATION" => $pagination));
$template->pparse("body"); $template->pparse("body");
} }