makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-11 13:58:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/17029] Use constants instead of magic numbers in tests

Browse source 
PHPBB3-17029
This commit is contained in:
Marc Alexander 2023-10-01 10:30:57 +02:00
parent 10330e5867
commit 4046365977
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
1 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
tests/content_visibility/set_post_visibility_test.php
View file

@ -30,8 +30,8 @@ class phpbb_content_visibility_set_post_visibility_test extends phpbb_database_t
2, time(), 'approve', 2, time(), 'approve',
true, false, true, false,
array( array(
array('post_id' => 1, 'post_visibility' => 1, 'post_delete_reason' => 'approve'), array('post_id' => 1, 'post_visibility' => ITEM_APPROVED, 'post_delete_reason' => 'approve'),
array('post_id' => 2, 'post_visibility' => 1, 'post_delete_reason' => ''), array('post_id' => 2, 'post_visibility' => ITEM_APPROVED, 'post_delete_reason' => ''),
array('post_id' => 3, 'post_visibility' => 2, 'post_delete_reason' => ''), array('post_id' => 3, 'post_visibility' => 2, 'post_delete_reason' => ''),
), ),
array( array(
@ -44,9 +44,9 @@ class phpbb_content_visibility_set_post_visibility_test extends phpbb_database_t
2, time(), 'approve', 2, time(), 'approve',
false, true, false, true,
array( array(
array('post_id' => 1, 'post_visibility' => 0, 'post_delete_reason' => ''), array('post_id' => 1, 'post_visibility' => ITEM_UNAPPROVED, 'post_delete_reason' => ''),
array('post_id' => 2, 'post_visibility' => 1, 'post_delete_reason' => ''), array('post_id' => 2, 'post_visibility' => ITEM_APPROVED, 'post_delete_reason' => ''),
array('post_id' => 3, 'post_visibility' => 1, 'post_delete_reason' => 'approve'), array('post_id' => 3, 'post_visibility' => ITEM_APPROVED, 'post_delete_reason' => 'approve'),
), ),
array( array(
array('topic_visibility' => 1, 'topic_first_post_id' => 2, 'topic_last_post_id' => 3), array('topic_visibility' => 1, 'topic_first_post_id' => 2, 'topic_last_post_id' => 3),
@ -58,7 +58,7 @@ class phpbb_content_visibility_set_post_visibility_test extends phpbb_database_t
2, time(), 'deleted', 2, time(), 'deleted',
true, true, true, true,
array( array(
array('post_id' => 1, 'post_visibility' => 0, 'post_delete_reason' => ''), array('post_id' => 1, 'post_visibility' => ITEM_UNAPPROVED, 'post_delete_reason' => ''),
array('post_id' => 2, 'post_visibility' => 2, 'post_delete_reason' => 'deleted'), array('post_id' => 2, 'post_visibility' => 2, 'post_delete_reason' => 'deleted'),
array('post_id' => 3, 'post_visibility' => 2, 'post_delete_reason' => ''), array('post_id' => 3, 'post_visibility' => 2, 'post_delete_reason' => ''),
), ),
@ -72,10 +72,10 @@ class phpbb_content_visibility_set_post_visibility_test extends phpbb_database_t
2, time(), 'deleted', 2, time(), 'deleted',
true, false, true, false,
array( array(
array('post_id' => 4, 'post_visibility' => 0, 'post_delete_reason' => ''), array('post_id' => 4, 'post_visibility' => ITEM_UNAPPROVED, 'post_delete_reason' => ''),
array('post_id' => 5, 'post_visibility' => 2, 'post_delete_reason' => 'deleted'), array('post_id' => 5, 'post_visibility' => ITEM_DELETED, 'post_delete_reason' => 'deleted'),
array('post_id' => 6, 'post_visibility' => 1, 'post_delete_reason' => ''), array('post_id' => 6, 'post_visibility' => ITEM_APPROVED, 'post_delete_reason' => ''),
array('post_id' => 7, 'post_visibility' => 2, 'post_delete_reason' => ''), array('post_id' => 7, 'post_visibility' => ITEM_DELETED, 'post_delete_reason' => ''),
), ),
array( array(
array('topic_visibility' => 1, 'topic_first_post_id' => 6, 'topic_last_post_id' => 6), array('topic_visibility' => 1, 'topic_first_post_id' => 6, 'topic_last_post_id' => 6),
@ -87,10 +87,10 @@ class phpbb_content_visibility_set_post_visibility_test extends phpbb_database_t
2, time(), 'deleted', 2, time(), 'deleted',
false, true, false, true,
array( array(
array('post_id' => 4, 'post_visibility' => 0, 'post_delete_reason' => ''), array('post_id' => 4, 'post_visibility' => ITEM_UNAPPROVED, 'post_delete_reason' => ''),
array('post_id' => 5, 'post_visibility' => 1, 'post_delete_reason' => ''), array('post_id' => 5, 'post_visibility' => ITEM_APPROVED, 'post_delete_reason' => ''),
array('post_id' => 6, 'post_visibility' => 2, 'post_delete_reason' => 'deleted'), array('post_id' => 6, 'post_visibility' => ITEM_DELETED, 'post_delete_reason' => 'deleted'),
array('post_id' => 7, 'post_visibility' => 2, 'post_delete_reason' => ''), array('post_id' => 7, 'post_visibility' => ITEM_DELETED, 'post_delete_reason' => ''),
), ),
array( array(
array('topic_visibility' => 1, 'topic_first_post_id' => 5, 'topic_last_post_id' => 5), array('topic_visibility' => 1, 'topic_first_post_id' => 5, 'topic_last_post_id' => 5),
@ -102,7 +102,7 @@ class phpbb_content_visibility_set_post_visibility_test extends phpbb_database_t
2, time(), 'deleted', 2, time(), 'deleted',
true, true, true, true,
array( array(
array('post_id' => 8, 'post_visibility' => 2, 'post_delete_reason' => 'deleted'), array('post_id' => 8, 'post_visibility' => ITEM_DELETED, 'post_delete_reason' => 'deleted'),
), ),
array( array(
array('topic_visibility' => 2, 'topic_first_post_id' => 8, 'topic_last_post_id' => 8), array('topic_visibility' => 2, 'topic_first_post_id' => 8, 'topic_last_post_id' => 8),