From 40bd4c8b721bccec4f889a035934fc8db3b66c92 Mon Sep 17 00:00:00 2001 From: lavigor Date: Sat, 27 Feb 2016 20:05:59 +0300 Subject: [PATCH] [ticket/14486] Use empty() and move error check. PHPBB3-14486 --- phpBB/includes/functions.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php index 985b5e8ca3..fca3ddf403 100644 --- a/phpBB/includes/functions.php +++ b/phpBB/includes/functions.php @@ -2848,7 +2848,7 @@ function login_box($redirect = '', $l_explain = '', $l_success = '', $admin = fa trigger_error('NO_AUTH_ADMIN'); } - if (($request->is_set_post('login') || ($request->is_set('login') && $request->variable('login', '') == 'external')) && !$err) + if (empty($err) && ($request->is_set_post('login') || ($request->is_set('login') && $request->variable('login', '') == 'external'))) { // Get credential if ($admin)