makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11509] Exit with the expected (non-zero) exit status on failure.

Browse source 
PHPBB3-11509
This commit is contained in:
Andreas Fischer 2014-02-21 01:44:41 +01:00
parent fe5858902e
commit 42e8c2e8cf
1 changed files with 22 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
git-tools/commit-msg-hook-range.sh
View file

@ -5,7 +5,6 @@
# #
# Calls the git commit-msg hook on all non-merge commits in a given commit range. # Calls the git commit-msg hook on all non-merge commits in a given commit range.
# #
set -e
if [ "$#" -ne 1 ]; if [ "$#" -ne 1 ];
then then
@ -14,10 +13,12 @@ then
fi fi
DIR=$(dirname "$0") DIR=$(dirname "$0")
COMMIT_MSG_HOOK_PATH="$DIR/hooks/commit-msg"
COMMIT_RANGE="$1" COMMIT_RANGE="$1"
COMMIT_MSG_HOOK_PATH="$DIR/hooks/commit-msg"
COMMIT_MSG_HOOK_FATAL=$(git config --bool phpbb.hooks.commit-msg.fatal 2> /dev/null)
git config phpbb.hooks.commit-msg.fatal true
EXIT_STATUS=0
for COMMIT_HASH in $(git rev-list --no-merges "$COMMIT_RANGE") for COMMIT_HASH in $(git rev-list --no-merges "$COMMIT_RANGE")
do do
echo "Inspecting commit message of commit $COMMIT_HASH" echo "Inspecting commit message of commit $COMMIT_HASH"
@ -27,6 +28,24 @@ do
# which then also needs to be deleted after our work is done. # which then also needs to be deleted after our work is done.
COMMIT_MESSAGE_PATH="$DIR/commit_msg.$COMMIT_HASH" COMMIT_MESSAGE_PATH="$DIR/commit_msg.$COMMIT_HASH"
git log -n 1 --pretty=format:%B "$COMMIT_HASH" > "$COMMIT_MESSAGE_PATH" git log -n 1 --pretty=format:%B "$COMMIT_HASH" > "$COMMIT_MESSAGE_PATH"
# Invoke hook on commit message file.
"$COMMIT_MSG_HOOK_PATH" "$COMMIT_MESSAGE_PATH" "$COMMIT_MSG_HOOK_PATH" "$COMMIT_MESSAGE_PATH"
# If any commit message hook complains with a non-zero exit status, we
# will send a non-zero exit status upstream.
if [ $? -ne 0 ]
then
EXIT_STATUS=1
fi
rm "$COMMIT_MESSAGE_PATH" rm "$COMMIT_MESSAGE_PATH"
done done
# Restore phpbb.hooks.commit-msg.fatal config
if [ -n "$COMMIT_MSG_HOOK_FATAL" ]
then
git config phpbb.hooks.commit-msg.fatal "$COMMIT_MSG_HOOK_FATAL"
fi
exit $EXIT_STATUS