makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/12514] Fix array formatting for tests

Browse source 
PHPBB3-12514
This commit is contained in:
Shitiz Garg 2014-06-20 14:47:20 +05:30
parent 3ac73a831a
commit 4472a492da
5 changed files with 241 additions and 241 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
tests/profilefields/type_bool_test.php
View file

@ -98,22 +98,22 @@ class phpbb_profilefield_type_bool_test extends phpbb_test_case
{ {
return array( return array(
array( array(
false, false,
array('field_show_novalue' => true), array('field_show_novalue' => true),
'No', 'No',
'Field should output the default value', 'Field should output the default value',
), ),
array( array(
false, false,
array('field_show_novalue' => false, 'field_length' => 2), array('field_show_novalue' => false, 'field_length' => 2),
null, null,
'Field should not show anything for empty value', 'Field should not show anything for empty value',
), ),
array( array(
0, 0,
array(), array(),
'Yes', 'Yes',
'Field should show the set value', 'Field should show the set value',
), ),
); );
} }

112
tests/profilefields/type_date_test.php
View file

@ -63,22 +63,22 @@ class phpbb_profilefield_type_date_test extends phpbb_test_case
{ {
return array( return array(
array( array(
'01-01-2009', '01-01-2009',
array('field_show_novalue' => true), array('field_show_novalue' => true),
'01/01/2009', '01/01/2009',
'Field should output the correctly formatted date', 'Field should output the correctly formatted date',
), ),
array( array(
null, null,
array('field_show_novalue' => false), array('field_show_novalue' => false),
null, null,
'Field should leave empty value as is', 'Field should leave empty value as is',
), ),
array( array(
'None', 'None',
array('field_show_novalue' => true), array('field_show_novalue' => true),
'None', 'None',
'Field should leave invalid value as is', 'Field should leave invalid value as is',
), ),
); );
} }
@ -99,70 +99,70 @@ class phpbb_profilefield_type_date_test extends phpbb_test_case
{ {
return array( return array(
array( array(
'', '',
array('field_required' => true), array('field_required' => true),
'FIELD_REQUIRED-field', 'FIELD_REQUIRED-field',
'Field should reject value for being empty', 'Field should reject value for being empty',
), ),
array( array(
'0125', '0125',
array('field_required' => true), array('field_required' => true),
'FIELD_REQUIRED-field', 'FIELD_REQUIRED-field',
'Field should reject value for being invalid', 'Field should reject value for being invalid',
), ),
array( array(
'01-01-2012', '01-01-2012',
array(), array(),
false, false,
'Field should accept a valid value', 'Field should accept a valid value',
), ),
array( array(
'40-05-2009', '40-05-2009',
array(), array(),
'FIELD_INVALID_DATE-field', 'FIELD_INVALID_DATE-field',
'Field should reject value for being invalid', 'Field should reject value for being invalid',
), ),
array( array(
'12-30-2012', '12-30-2012',
array(), array(),
'FIELD_INVALID_DATE-field', 'FIELD_INVALID_DATE-field',
'Field should reject value for being invalid', 'Field should reject value for being invalid',
), ),
array( array(
'string', 'string',
array(), array(),
false, false,
'Field should reject value for being invalid', 'Field should reject value for being invalid',
), ),
array( array(
'string', 'string',
array('field_required' => true), array('field_required' => true),
'FIELD_REQUIRED-field', 'FIELD_REQUIRED-field',
'Field should reject value for being invalid', 'Field should reject value for being invalid',
), ),
array( array(
100, 100,
array(), array(),
false, false,
'Field should reject value for being invalid', 'Field should reject value for being invalid',
), ),
array( array(
100, 100,
array('field_required' => true), array('field_required' => true),
'FIELD_REQUIRED-field', 'FIELD_REQUIRED-field',
'Field should reject value for being invalid', 'Field should reject value for being invalid',
), ),
array( array(
null, null,
array('field_required' => true), array('field_required' => true),
'FIELD_REQUIRED-field', 'FIELD_REQUIRED-field',
'Field should reject value for being empty', 'Field should reject value for being empty',
), ),
array( array(
true, true,
array('field_required' => true), array('field_required' => true),
'FIELD_REQUIRED-field', 'FIELD_REQUIRED-field',
'Field should reject value for being empty', 'Field should reject value for being empty',
), ),
); );
} }

80
tests/profilefields/type_dropdown_test.php
View file

@ -77,40 +77,40 @@ class phpbb_profilefield_type_dropdown_test extends phpbb_test_case
{ {
return array( return array(
array( array(
7, 7,
array(), array(),
'FIELD_INVALID_VALUE-field', 'FIELD_INVALID_VALUE-field',
'Invalid value should throw error', 'Invalid value should throw error',
), ),
array( array(
true, true,
array('field_required' => true), array('field_required' => true),
false, false,
'Boolean would evaluate to 1 and hence correct value', 'Boolean would evaluate to 1 and hence correct value',
), ),
array( array(
'string', 'string',
array('field_required' => true), array('field_required' => true),
'FIELD_REQUIRED-field', 'FIELD_REQUIRED-field',
'String should be rejected for value', 'String should be rejected for value',
), ),
array( array(
2, 2,
array(), array(),
false, false,
'Valid value should not throw error' 'Valid value should not throw error'
), ),
array( array(
0, 0,
array(), array(),
false, false,
'Empty value should be acceptible', 'Empty value should be acceptible',
), ),
array( array(
0, 0,
array('field_required' => true), array('field_required' => true),
'FIELD_REQUIRED-field', 'FIELD_REQUIRED-field',
'Required field should not accept empty value', 'Required field should not accept empty value',
), ),
); );
} }
@ -131,28 +131,28 @@ class phpbb_profilefield_type_dropdown_test extends phpbb_test_case
{ {
return array( return array(
array( array(
1, 1,
array('field_show_novalue' => true), array('field_show_novalue' => true),
'Option 1', 'Option 1',
'Field should output the given value', 'Field should output the given value',
), ),
array( array(
4, 4,
array('field_show_novalue' => false), array('field_show_novalue' => false),
'Option 4', 'Option 4',
'Field should output the given value', 'Field should output the given value',
), ),
array( array(
'', '',
array('field_show_novalue' => true), array('field_show_novalue' => true),
'<No Value>', '<No Value>',
'Field should output nothing for empty value', 'Field should output nothing for empty value',
), ),
array( array(
'', '',
array('field_show_novalue' => false), array('field_show_novalue' => false),
null, null,
'Field should simply output null for empty value', 'Field should simply output null for empty value',
), ),
); );
} }

122
tests/profilefields/type_int_test.php
View file

@ -52,60 +52,60 @@ class phpbb_profilefield_type_int_test extends phpbb_test_case
{ {
return array( return array(
array( array(
'10', '10',
array('field_show_novalue' => true), array('field_show_novalue' => true),
10, 10,
'Field should output integer value of given input', 'Field should output integer value of given input',
), ),
array( array(
'0', '0',
array('field_show_novalue' => true), array('field_show_novalue' => true),
0, 0,
'Field should output integer value of given input', 'Field should output integer value of given input',
), ),
array( array(
'', '',
array('field_show_novalue' => true), array('field_show_novalue' => true),
0, 0,
'Field should translate empty value to 0 as integer', 'Field should translate empty value to 0 as integer',
false, false,
), ),
array( array(
null, null,
array('field_show_novalue' => true), array('field_show_novalue' => true),
0, 0,
'Field should translate null value to 0 as integer', 'Field should translate null value to 0 as integer',
), ),
array( array(
'10', '10',
array('field_show_novalue' => false), array('field_show_novalue' => false),
10, 10,
'Field should output integer value of given input', 'Field should output integer value of given input',
), ),
array( array(
'0', '0',
array('field_show_novalue' => false), array('field_show_novalue' => false),
0, 0,
'Field should output integer value of given input', 'Field should output integer value of given input',
), ),
array( array(
'', '',
array('field_show_novalue' => false), array('field_show_novalue' => false),
null, null,
'Field should leave empty value as is', 'Field should leave empty value as is',
), ),
array( array(
null, null,
array('field_show_novalue' => false), array('field_show_novalue' => false),
null, null,
'Field should leave empty value as is', 'Field should leave empty value as is',
), ),
); );
} }
/** /**
* @dataProvider profile_value_data * @dataProvider profile_value_data
*/ */
public function test_get_profile_value($value, $field_options, $expected, $description) public function test_get_profile_value($value, $field_options, $expected, $description)
{ {
$field_options = array_merge($this->field_options, $field_options); $field_options = array_merge($this->field_options, $field_options);
@ -119,47 +119,47 @@ class phpbb_profilefield_type_int_test extends phpbb_test_case
{ {
return array( return array(
array( array(
'15', '15',
array('field_minlen' => 10, 'field_maxlen' => 20, 'field_required' => true), array('field_minlen' => 10, 'field_maxlen' => 20, 'field_required' => true),
false, false,
'Field should accept input of correct boundaries', 'Field should accept input of correct boundaries',
), ),
array( array(
'556476', '556476',
array('field_maxlen' => 50000, 'field_required' => true), array('field_maxlen' => 50000, 'field_required' => true),
'FIELD_TOO_LARGE-50000-field', 'FIELD_TOO_LARGE-50000-field',
'Field should reject value of greater value than max', 'Field should reject value of greater value than max',
), ),
array( array(
'9', '9',
array('field_minlen' => 10, 'field_required' => true), array('field_minlen' => 10, 'field_required' => true),
'FIELD_TOO_SMALL-10-field', 'FIELD_TOO_SMALL-10-field',
'Field should reject value which is less than defined minimum', 'Field should reject value which is less than defined minimum',
), ),
array( array(
true, true,
array('field_maxlen' => 20), array('field_maxlen' => 20),
false, false,
'Field should accept correct boolean value', 'Field should accept correct boolean value',
), ),
array( array(
'string', 'string',
array('field_maxlen' => 10, 'field_required' => true), array('field_maxlen' => 10, 'field_required' => true),
false, false,
'Field should accept correct string value', 'Field should accept correct string value',
), ),
array( array(
null, null,
array('field_minlen' => 1, 'field_maxlen' => 10, 'field_required' => true), array('field_minlen' => 1, 'field_maxlen' => 10, 'field_required' => true),
'FIELD_TOO_SMALL-1-field', 'FIELD_TOO_SMALL-1-field',
'Field should not accept an empty value', 'Field should not accept an empty value',
), ),
); );
} }
/** /**
* @dataProvider validate_profile_field_data * @dataProvider validate_profile_field_data
*/ */
public function test_validate_profile_field($value, $field_options, $expected, $description) public function test_validate_profile_field($value, $field_options, $expected, $description)
{ {
$field_options = array_merge($this->field_options, $field_options); $field_options = array_merge($this->field_options, $field_options);

144
tests/profilefields/type_string_test.php
View file

@ -60,88 +60,88 @@ class phpbb_profilefield_type_string_test extends phpbb_test_case
{ {
return array( return array(
array( array(
'', '',
array('field_required' => true), array('field_required' => true),
'FIELD_REQUIRED-field', 'FIELD_REQUIRED-field',
'Field should not accept empty values for required fields', 'Field should not accept empty values for required fields',
), ),
array( array(
null, null,
array('field_required' => true), array('field_required' => true),
'FIELD_REQUIRED-field', 'FIELD_REQUIRED-field',
'Field should not accept empty values for required field', 'Field should not accept empty values for required field',
), ),
array( array(
0, 0,
array('field_required' => true), array('field_required' => true),
false, false,
'Field should accept a non-empty input', 'Field should accept a non-empty input',
), ),
array( array(
'false', 'false',
array('field_required' => true), array('field_required' => true),
false, false,
'Field should accept a non-empty input', 'Field should accept a non-empty input',
), ),
array( array(
10, 10,
array('field_required' => true), array('field_required' => true),
false, false,
'Field should accept a non-empty input', 'Field should accept a non-empty input',
), ),
array( array(
'tas', 'tas',
array('field_minlen' => 2, 'field_maxlen' => 5), array('field_minlen' => 2, 'field_maxlen' => 5),
false, false,
'Field should accept value of correct length', 'Field should accept value of correct length',
), ),
array( array(
't', 't',
array('field_minlen' => 2, 'field_maxlen' => 5), array('field_minlen' => 2, 'field_maxlen' => 5),
'FIELD_TOO_SHORT-2-field', 'FIELD_TOO_SHORT-2-field',
'Field should reject value of incorrect length', 'Field should reject value of incorrect length',
), ),
array( array(
'this is a long string', 'this is a long string',
array('field_minlen' => 2, 'field_maxlen' => 5), array('field_minlen' => 2, 'field_maxlen' => 5),
'FIELD_TOO_LONG-5-field', 'FIELD_TOO_LONG-5-field',
'Field should reject value of incorrect length', 'Field should reject value of incorrect length',
), ),
array( array(
'H3110', 'H3110',
array('field_validation' => '[0-9]+'), array('field_validation' => '[0-9]+'),
'FIELD_INVALID_CHARS_NUMBERS_ONLY-field', 'FIELD_INVALID_CHARS_NUMBERS_ONLY-field',
'Required field should reject characters in a numbers-only field', 'Required field should reject characters in a numbers-only field',
), ),
array( array(
'&lt;&gt;&quot;&amp;%&amp;&gt;&lt;&gt;', '&lt;&gt;&quot;&amp;%&amp;&gt;&lt;&gt;',
array('field_maxlen' => 10, 'field_minlen' => 2), array('field_maxlen' => 10, 'field_minlen' => 2),
false, false,
'Optional field should accept html entities', 'Optional field should accept html entities',
), ),
array( array(
'ö ä ü ß', 'ö ä ü ß',
array(), array(),
false, false,
'Required field should accept UTF-8 string', 'Required field should accept UTF-8 string',
), ),
array( array(
'This ö ä string has to b', 'This ö ä string has to b',
array('field_maxlen' => 10), array('field_maxlen' => 10),
'FIELD_TOO_LONG-10-field', 'FIELD_TOO_LONG-10-field',
'Required field should reject an UTF-8 string which is too long', 'Required field should reject an UTF-8 string which is too long',
), ),
array( array(
'ö äö äö ä', 'ö äö äö ä',
array('field_validation' => '[\w]+'), array('field_validation' => '[\w]+'),
'FIELD_INVALID_CHARS_ALPHA_ONLY-field', 'FIELD_INVALID_CHARS_ALPHA_ONLY-field',
'Required field should reject UTF-8 in alpha only field', 'Required field should reject UTF-8 in alpha only field',
), ),
array( array(
'Hello', 'Hello',
array('field_validation' => '[\w]+'), array('field_validation' => '[\w]+'),
false, false,
'Required field should accept a characters only field', 'Required field should accept a characters only field',
), ),
); );
} }
@ -162,28 +162,28 @@ class phpbb_profilefield_type_string_test extends phpbb_test_case
{ {
return array( return array(
array( array(
'test', 'test',
array('field_show_novalue' => true), array('field_show_novalue' => true),
'test', 'test',
'Field should output the given value', 'Field should output the given value',
), ),
array( array(
'test', 'test',
array('field_show_novalue' => false), array('field_show_novalue' => false),
'test', 'test',
'Field should output the given value', 'Field should output the given value',
), ),
array( array(
'', '',
array('field_show_novalue' => true), array('field_show_novalue' => true),
'', '',
'Field should output nothing for empty value', 'Field should output nothing for empty value',
), ),
array( array(
'', '',
array('field_show_novalue' => false), array('field_show_novalue' => false),
null, null,
'Field should simply output null for empty vlaue', 'Field should simply output null for empty vlaue',
), ),
); );
} }