From 4618a3e2f83d7967f41bef52a2e996b610febfbb Mon Sep 17 00:00:00 2001 From: RMcGirr83 Date: Wed, 4 Mar 2015 14:20:27 -0500 Subject: [PATCH] [ticket/13477] rename function and fix doc blocks PHPBB3-13477 --- phpBB/phpbb/cache/driver/file.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/phpBB/phpbb/cache/driver/file.php b/phpBB/phpbb/cache/driver/file.php index bc8da19401..9a7c4aec7f 100644 --- a/phpBB/phpbb/cache/driver/file.php +++ b/phpBB/phpbb/cache/driver/file.php @@ -279,7 +279,7 @@ class file extends \phpbb\cache\driver\base if ($var_name[0] == '_') { global $phpEx; - $var_name = $this->replace_slashes($var_name); + $var_name = $this->clean_varname($var_name); return file_exists($this->cache_dir . 'data' . $var_name . ".$phpEx"); } else @@ -335,7 +335,7 @@ class file extends \phpbb\cache\driver\base { global $phpEx; - $filename = $this->replace_slashes($filename); + $filename = $this->clean_varname($filename); $file = "{$this->cache_dir}$filename.$phpEx"; $type = substr($filename, 0, strpos($filename, '_')); @@ -518,7 +518,7 @@ class file extends \phpbb\cache\driver\base { global $phpEx; - $filename = $this->replace_slashes($filename); + $filename = $this->clean_varname($filename); $file = "{$this->cache_dir}$filename.$phpEx"; $lock = new \phpbb\lock\flock($file); @@ -591,11 +591,11 @@ class file extends \phpbb\cache\driver\base /** * Replace slashes in the file name * - * @param string $name filename - * @return string the corrected name + * @param string $varname name of a cache variable + * @return string $varname name that is safe to use as a filename */ - function replace_slashes($name) + protected function clean_varname($varname) { - return str_replace('/', '-', $name); + return str_replace('/', '-', $varname); } }