makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-10 21:38:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10411] Add a comment why we left join the group table

Browse source 
We left join the group table because we want to check that the group
does exist there aswell.

PHPBB3-10411
This commit is contained in:
Joas Schilling 2013-01-15 13:20:35 +01:00
parent 780a8c98ac
commit 46b75f4cf9
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
phpBB/includes/groupposition/teampage.php
View file

@ -88,6 +88,7 @@ class phpbb_groupposition_teampage implements phpbb_groupposition_interface
*/
public function get_group_value($group_id)
{
// The join is required to ensure that the group itself exists
$sql = 'SELECT g.group_id, t.teampage_position
FROM ' . GROUPS_TABLE . ' g
LEFT JOIN ' . TEAMPAGE_TABLE . ' t
@ -114,6 +115,7 @@ class phpbb_groupposition_teampage implements phpbb_groupposition_interface
*/
public function get_group_values($group_id)
{
// The join is required to ensure that the group itself exists
$sql = 'SELECT *
FROM ' . GROUPS_TABLE . ' g
LEFT JOIN ' . TEAMPAGE_TABLE . ' t