makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 22:28:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10100] Update rand_seed_last_update before rand_seed in unique_id().

Browse source 
Update $config['rand_seed_last_update'] before updating $config['rand_seed'] in
unique_id() to mitigate a race condition and unnecessary updates on heavily
busy boards.

PHPBB3-10100
This commit is contained in:
Andreas Fischer 2011-03-17 23:01:07 +01:00
parent 784132d7e8
commit 48ba841be0
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
phpBB/includes/functions.php
View file

@ -240,8 +240,8 @@ function unique_id($extra = 'c')
if ($dss_seeded !== true && ($config['rand_seed_last_update'] < time() - rand(1,10))) if ($dss_seeded !== true && ($config['rand_seed_last_update'] < time() - rand(1,10)))
{ {
set_config('rand_seed', $config['rand_seed'], true);
set_config('rand_seed_last_update', time(), true); set_config('rand_seed_last_update', time(), true);
set_config('rand_seed', $config['rand_seed'], true);
$dss_seeded = true; $dss_seeded = true;
} }