makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/11202] Add a heuristic function to check for response success.

Browse source 
This tries to account for php sending fatal errors with 200 status code.

PHPBB3-11202
This commit is contained in:
Oleg Pudeyev 2012-11-15 08:19:40 -05:00
parent 8b156c3d83
commit 4ab178f3ef
1 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tests/test_framework/phpbb_functional_test_case.php
View file

@ -182,7 +182,7 @@ class phpbb_functional_test_case extends phpbb_test_case
$login = $this->client->submit($form, array('username' => 'admin', 'password' => 'admin')); $login = $this->client->submit($form, array('username' => 'admin', 'password' => 'admin'));
$cookies = $this->cookieJar->all(); $cookies = $this->cookieJar->all();
// The session id is stored in a cookie that ends with _sid - we assume there is only one such cookie // The session id is stored in a cookie that ends with _sid - we assume there is only one such cookie
foreach ($cookies as $cookie); foreach ($cookies as $cookie);
{ {
@ -229,4 +229,19 @@ class phpbb_functional_test_case extends phpbb_test_case
return call_user_func_array('sprintf', $args); return call_user_func_array('sprintf', $args);
} }
/**
* Heuristic function to check that the response is success.
*
* When php decides to die with a fatal error, it still sends 200 OK
* status code. This assertion tries to catch that.
*
* @param string $message Optional failure message
*/
public function assert_response_success($message = null)
{
$this->assertEquals(200, $this->client->getResponse()->getStatus());
$content = $this->client->getResponse()->getContent();
$this->assertNotContains('Fatal error:', $content);
}
} }