makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/15055] Add comments explaining overriden createXMLDataSet()

Browse source 
PHPBB3-15055
This commit is contained in:
Marc Alexander 2018-01-01 18:00:51 +01:00
parent ee8b72d733
commit 4afb53dd8d
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
tests/test_framework/phpbb_database_test_case.php
View file

@ -142,9 +142,17 @@ abstract class phpbb_database_test_case extends PHPUnit_Extensions_Database_Test
$manager->database_synchronisation($table_column_map); $manager->database_synchronisation($table_column_map);
} }
/**
* Create xml data set for insertion into database
*
* @param string $path Path to fixture XML
* @return PHPUnit_Extensions_Database_DataSet_DefaultDataSet|PHPUnit_Extensions_Database_DataSet_XmlDataSet
*/
public function createXMLDataSet($path) public function createXMLDataSet($path)
{ {
$this->fixture_xml_data = parent::createXMLDataSet($path); $this->fixture_xml_data = parent::createXMLDataSet($path);
// Extend XML data set on MSSQL
if (strpos($this->get_database_config()['dbms'], 'mssql') !== false) if (strpos($this->get_database_config()['dbms'], 'mssql') !== false)
{ {
$newXmlData = new PHPUnit_Extensions_Database_DataSet_DefaultDataSet(); $newXmlData = new PHPUnit_Extensions_Database_DataSet_DefaultDataSet();
@ -165,6 +173,11 @@ abstract class phpbb_database_test_case extends PHPUnit_Extensions_Database_Test
$identity_columns = $db->sql_fetchrowset($result); $identity_columns = $db->sql_fetchrowset($result);
$has_default_identity = false; $has_default_identity = false;
$add_primary_keys = false; $add_primary_keys = false;
// Iterate over identity columns to check for missing primary
// keys in data set and special identity column 'mssqlindex'
// that might have been added when no default identity column
// exists in the current table.
foreach ($identity_columns as $column) foreach ($identity_columns as $column)
{ {
if (in_array($column['identity_column'], $columns) && !in_array($column['identity_column'], $primaryKeys)) if (in_array($column['identity_column'], $columns) && !in_array($column['identity_column'], $primaryKeys))
@ -182,6 +195,7 @@ abstract class phpbb_database_test_case extends PHPUnit_Extensions_Database_Test
if ($has_default_identity || $add_primary_keys) if ($has_default_identity || $add_primary_keys)
{ {
// Add default identity column to columns list
if ($has_default_identity) if ($has_default_identity)
{ {
$columns[] = 'mssqlindex'; $columns[] = 'mssqlindex';