diff --git a/phpBB/admin/admin_disallow.php b/phpBB/admin/admin_disallow.php
index c6ab26befd..87c12fcaca 100644
--- a/phpBB/admin/admin_disallow.php
+++ b/phpBB/admin/admin_disallow.php
@@ -23,27 +23,41 @@ define('IN_PHPBB', 1);
if( !empty($setmodules) )
{
+ if ( !$acl->get_acl_admin('user') )
+ {
+ return;
+ }
+
$filename = basename(__FILE__);
$module['Users']['Disallow'] = $filename . $SID;
return;
}
+define('IN_PHPBB', 1);
//
-// Include required files, get $phpEx and check permissions
+// Include files
//
-$phpbb_root_path = "../";
+$phpbb_root_path = '../';
require($phpbb_root_path . 'extension.inc');
require('pagestart.' . $phpEx);
+//
+// Do we have user admin permissions?
+//
+if ( !$acl->get_acl_admin('user') )
+{
+ return;
+}
+
if( isset($HTTP_POST_VARS['add_name']) )
{
include($phpbb_root_path . 'includes/functions_validate.'.$phpEx);
$disallowed_user = ( isset($HTTP_POST_VARS['disallowed_user']) ) ? $HTTP_POST_VARS['disallowed_user'] : $HTTP_GET_VARS['disallowed_user'];
- $disallowed_user = preg_replace( '/\*/', '%', $disallowed_user );
+ $disallowed_user = str_replace('*', '%', $disallowed_user);
- if( !validate_username($disallowed_user) )
+ if ( !validate_username($disallowed_user) )
{
$message = $lang['Disallowed_already'];
}
@@ -52,16 +66,15 @@ if( isset($HTTP_POST_VARS['add_name']) )
$sql = "INSERT INTO " . DISALLOW_TABLE . " (disallow_username)
VALUES('" . str_replace("\'", "''", $disallowed_user) . "')";
$result = $db->sql_query( $sql );
- if ( !$result )
- {
- message_die(GENERAL_ERROR, "Could not add disallowed user.", "",__LINE__, __FILE__, $sql);
- }
+
$message = $lang['Disallow_successful'];
}
- $message .= "
" . sprintf($lang['Click_return_disallowadmin'], "", "") . "
" . sprintf($lang['Click_return_admin_index'], "", "");
+ $message .= '
' . sprintf($lang['Click_return_disallowadmin'], '', '') . '
' . sprintf($lang['Click_return_admin_index'], '', '');
- message_die(GENERAL_MESSAGE, $message);
+ add_admin_log('log_disallow_add', str_replace('%', '*', $disallowed_user));
+
+ message_die(MESSAGE, $message);
}
else if( isset($HTTP_POST_VARS['delete_name']) )
{
@@ -69,15 +82,13 @@ else if( isset($HTTP_POST_VARS['delete_name']) )
$sql = "DELETE FROM " . DISALLOW_TABLE . "
WHERE disallow_id = $disallowed_id";
- $result = $db->sql_query($sql);
- if( !$result )
- {
- message_die(GENERAL_ERROR, "Couldn't removed disallowed user.", "",__LINE__, __FILE__, $sql);
- }
+ $db->sql_query($sql);
- $message .= $lang['Disallowed_deleted'] . "
" . sprintf($lang['Click_return_disallowadmin'], "", "") . "
" . sprintf($lang['Click_return_admin_index'], "", "");
+ $message .= $lang['Disallowed_deleted'] . '
' . sprintf($lang['Click_return_disallowadmin'], '', '') . '
' . sprintf($lang['Click_return_admin_index'], '', '');
- message_die(GENERAL_MESSAGE, $message);
+ add_admin_log('log_disallow_delete');
+
+ message_die(MESSAGE, $message);
}
@@ -87,56 +98,51 @@ else if( isset($HTTP_POST_VARS['delete_name']) )
$sql = "SELECT *
FROM " . DISALLOW_TABLE;
$result = $db->sql_query($sql);
-if( !$result )
-{
- message_die(GENERAL_ERROR, "Couldn't get disallowed users.", "", __LINE__, __FILE__, $sql );
-}
-$disallowed = $db->sql_fetchrowset($result);
-
-//
-// Ok now generate the info for the template, which will be put out no matter
-// what mode we are in.
-//
-$disallow_select = '';
+//
+// Output page
+//
+page_header($lang['Users']);
-$template->set_filenames(array(
- "body" => "admin/disallow_body.tpl")
-);
+?>
-$template->assign_vars(array(
- "S_DISALLOW_SELECT" => $disallow_select,
- "S_FORM_ACTION" => append_sid("admin_disallow.$phpEx"),
+