makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 22:28:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/13733] Properly handle nonexistent classes as well

Browse source 
PHPBB3-13733
This commit is contained in:
David King 2015-05-23 20:13:23 -04:00
parent 9e6f9c8a64
commit 4ecc13af83
1 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
phpBB/phpbb/extension/base.php
View file

@ -139,11 +139,21 @@ class base implements \phpbb\extension\extension_interface
foreach ($migrations as $key => $migration) foreach ($migrations as $key => $migration)
{ {
// If the class doesn't exist OR the class does not extend the migration class // If the class exists and is a subclass of the
// we need to skip it. // \phpbb\db\migration\migration abstract class
if (!class_exists($migration) || ($reflector = new \ReflectionClass($migration) && !$reflector->isSubclassOf('\phpbb\db\migration\migration'))) { // we skip it.
unset($migrations[$key]);
// Otherwise, i.e. if it doesn't exist or it is
// not an extend the abstract class, we unset it
if (class_exists($migration)) {
$reflector = new \ReflectionClass($migration);
if ($reflector->isSubclassOf('\phpbb\db\migration\migration')) {
continue;
}
} }
unset($migrations[$key]);
} }
return $migrations; return $migrations;