makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-12 06:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/10320] Exclude passworded forums when determining "Most active topic".

Browse source 
PHPBB3-10320
This commit is contained in:
Andreas Fischer 2011-08-25 17:33:39 +02:00
parent 4491746c73
commit 4f8bb02a57
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
phpBB/includes/functions_display.php
View file

@ -996,13 +996,17 @@ function display_user_activity(&$userdata)
} }
// Obtain active topic // Obtain active topic
// We need to exclude passworded forums here so we do not leak the topic title
$forum_ary_topic = array_unique(array_merge($forum_ary, $user->get_passworded_forums()));
$forum_sql_topic = (!empty($forum_ary_topic)) ? 'AND ' . $db->sql_in_set('forum_id', $forum_ary_topic, true) : '';
$sql = 'SELECT topic_id, COUNT(post_id) AS num_posts $sql = 'SELECT topic_id, COUNT(post_id) AS num_posts
FROM ' . POSTS_TABLE . ' FROM ' . POSTS_TABLE . '
WHERE poster_id = ' . $userdata['user_id'] . " WHERE poster_id = ' . $userdata['user_id'] . "
AND post_postcount = 1 AND post_postcount = 1
AND (post_approved = 1 AND (post_approved = 1
$sql_m_approve) $sql_m_approve)
$forum_sql $forum_sql_topic
GROUP BY topic_id GROUP BY topic_id
ORDER BY num_posts DESC"; ORDER BY num_posts DESC";
$result = $db->sql_query_limit($sql, 1); $result = $db->sql_query_limit($sql, 1);