makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-08 04:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/17296] Ensure session page update test actually runs

Browse source 
PHPBB3-17296
This commit is contained in:
Marc Alexander 2024-03-07 21:11:26 +01:00
parent bda99e1c35
commit 51b3d9de63
No known key found for this signature in database
GPG key ID: 50E0D2423696F995
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tests/functional/session_page_update_test.php
View file

@ -17,7 +17,16 @@
class phpbb_functional_session_page_update_test extends phpbb_functional_test_case class phpbb_functional_session_page_update_test extends phpbb_functional_test_case
{ {
protected function test_session_page_update() public function setUp(): void
{
parent::setUp();
global $db;
$db = $this->db;
}
public function test_session_page_update()
{ {
$this->login(); $this->login();
$db = $this->get_db(); $db = $this->get_db();
@ -32,7 +41,7 @@ class phpbb_functional_session_page_update_test extends phpbb_functional_test_ca
} }
$user_ids = []; $user_ids = [];
$username = [$this->get_logged_in_user()]; $username = ['admin'];
user_get_id_name($user_ids, $username); user_get_id_name($user_ids, $username);
$user_id = (int) $user_ids[0]; $user_id = (int) $user_ids[0];
@ -45,7 +54,7 @@ class phpbb_functional_session_page_update_test extends phpbb_functional_test_ca
$this->assertEquals('index.php', $db->sql_fetchfield('session_page')); $this->assertEquals('index.php', $db->sql_fetchfield('session_page'));
// Request non-existent url // Request non-existent url
self::request('GET', 'nonexistent.jpg'); self::request('GET', 'nonexistent.jpg', [], false);
$this->assertEquals(404, self::$client->getResponse()->getStatus()); $this->assertEquals(404, self::$client->getResponse()->getStatus());
$db->sql_query_limit($sql, 1); $db->sql_query_limit($sql, 1);