mirror of
https://github.com/phpbb/phpbb.git
synced 2025-06-28 22:28:51 +00:00
[ticket/13455] Remove request_var()
references from comments
PHPBB3-13455
This commit is contained in:
parent
abcb2680ee
commit
52446c8327
8 changed files with 10 additions and 10 deletions
|
@ -512,7 +512,7 @@ class acp_forums
|
||||||
{
|
{
|
||||||
if (!isset($forum_data['forum_rules_uid']))
|
if (!isset($forum_data['forum_rules_uid']))
|
||||||
{
|
{
|
||||||
// Before we are able to display the preview and plane text, we need to parse our request_var()'d value...
|
// Before we are able to display the preview and plane text, we need to parse our $request->variable()'d value...
|
||||||
$forum_data['forum_rules_uid'] = '';
|
$forum_data['forum_rules_uid'] = '';
|
||||||
$forum_data['forum_rules_bitfield'] = '';
|
$forum_data['forum_rules_bitfield'] = '';
|
||||||
$forum_data['forum_rules_options'] = 0;
|
$forum_data['forum_rules_options'] = 0;
|
||||||
|
@ -532,7 +532,7 @@ class acp_forums
|
||||||
{
|
{
|
||||||
if (!isset($forum_data['forum_desc_uid']))
|
if (!isset($forum_data['forum_desc_uid']))
|
||||||
{
|
{
|
||||||
// Before we are able to display the preview and plane text, we need to parse our request_var()'d value...
|
// Before we are able to display the preview and plane text, we need to parse our $request->variable()'d value...
|
||||||
$forum_data['forum_desc_uid'] = '';
|
$forum_data['forum_desc_uid'] = '';
|
||||||
$forum_data['forum_desc_bitfield'] = '';
|
$forum_data['forum_desc_bitfield'] = '';
|
||||||
$forum_data['forum_desc_options'] = 0;
|
$forum_data['forum_desc_options'] = 0;
|
||||||
|
|
|
@ -507,7 +507,7 @@ function generate_text_for_display($text, $uid, $bitfield, $flags, $censor_text
|
||||||
/**
|
/**
|
||||||
* For parsing custom parsed text to be stored within the database.
|
* For parsing custom parsed text to be stored within the database.
|
||||||
* This function additionally returns the uid and bitfield that needs to be stored.
|
* This function additionally returns the uid and bitfield that needs to be stored.
|
||||||
* Expects $text to be the value directly from request_var() and in it's non-parsed form
|
* Expects $text to be the value directly from $request->variable() and in it's non-parsed form
|
||||||
*
|
*
|
||||||
* @param string $text The text to be replaced with the parsed one
|
* @param string $text The text to be replaced with the parsed one
|
||||||
* @param string $uid The BBCode uid for this parse
|
* @param string $uid The BBCode uid for this parse
|
||||||
|
|
|
@ -473,7 +473,7 @@ function compose_pm($id, $mode, $action, $user_folders = array())
|
||||||
if ($action == 'delete')
|
if ($action == 'delete')
|
||||||
{
|
{
|
||||||
// Folder id has been determined by the SQL Statement
|
// Folder id has been determined by the SQL Statement
|
||||||
// $folder_id = request_var('f', PRIVMSGS_NO_BOX);
|
// $folder_id = $request->variable('f', PRIVMSGS_NO_BOX);
|
||||||
|
|
||||||
// Do we need to confirm ?
|
// Do we need to confirm ?
|
||||||
if (confirm_box(true))
|
if (confirm_box(true))
|
||||||
|
@ -1379,7 +1379,7 @@ function handle_message_list_actions(&$address_list, &$error, $remove_u, $remove
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Build the hidden field for the recipients. Needed, as the variable is not read via request_var.
|
* Build the hidden field for the recipients. Needed, as the variable is not read via $request->variable().
|
||||||
*/
|
*/
|
||||||
function build_address_field($address_list)
|
function build_address_field($address_list)
|
||||||
{
|
{
|
||||||
|
|
|
@ -428,7 +428,7 @@ class install_convert extends module
|
||||||
// Default URL of the old board
|
// Default URL of the old board
|
||||||
// @todo Are we going to use this for attempting to convert URL references in posts, or should we remove it?
|
// @todo Are we going to use this for attempting to convert URL references in posts, or should we remove it?
|
||||||
// -> We should convert old urls to the new relative urls format
|
// -> We should convert old urls to the new relative urls format
|
||||||
// $src_url = request_var('src_url', 'Not in use at the moment');
|
// $src_url = $request->variable('src_url', 'Not in use at the moment');
|
||||||
|
|
||||||
// strip trailing slash from old forum path
|
// strip trailing slash from old forum path
|
||||||
$forum_path = (strlen($forum_path) && $forum_path[strlen($forum_path) - 1] == '/') ? substr($forum_path, 0, -1) : $forum_path;
|
$forum_path = (strlen($forum_path) && $forum_path[strlen($forum_path) - 1] == '/') ? substr($forum_path, 0, -1) : $forum_path;
|
||||||
|
|
|
@ -1189,7 +1189,7 @@ switch ($mode)
|
||||||
// Build a relevant pagination_url
|
// Build a relevant pagination_url
|
||||||
$params = $sort_params = array();
|
$params = $sort_params = array();
|
||||||
|
|
||||||
// We do not use request_var() here directly to save some calls (not all variables are set)
|
// We do not use $request->variable() here directly to save some calls (not all variables are set)
|
||||||
$check_params = array(
|
$check_params = array(
|
||||||
'g' => array('g', 0),
|
'g' => array('g', 0),
|
||||||
'sk' => array('sk', $default_key),
|
'sk' => array('sk', $default_key),
|
||||||
|
|
|
@ -31,7 +31,7 @@ class prune_forum extends \phpbb\cron\task\base implements \phpbb\cron\task\para
|
||||||
* If $forum_data is given, it is assumed to contain necessary information
|
* If $forum_data is given, it is assumed to contain necessary information
|
||||||
* about a single forum that is to be pruned.
|
* about a single forum that is to be pruned.
|
||||||
*
|
*
|
||||||
* If $forum_data is not given, forum id will be retrieved via request_var
|
* If $forum_data is not given, forum id will be retrieved via $request->variable()
|
||||||
* and a database query will be performed to load the necessary information
|
* and a database query will be performed to load the necessary information
|
||||||
* about the forum.
|
* about the forum.
|
||||||
*/
|
*/
|
||||||
|
|
|
@ -33,7 +33,7 @@ class prune_shadow_topics extends \phpbb\cron\task\base implements \phpbb\cron\t
|
||||||
* If $forum_data is given, it is assumed to contain necessary information
|
* If $forum_data is given, it is assumed to contain necessary information
|
||||||
* about a single forum that is to be pruned.
|
* about a single forum that is to be pruned.
|
||||||
*
|
*
|
||||||
* If $forum_data is not given, forum id will be retrieved via request_var
|
* If $forum_data is not given, forum id will be retrieved via $request->variable()
|
||||||
* and a database query will be performed to load the necessary information
|
* and a database query will be performed to load the necessary information
|
||||||
* about the forum.
|
* about the forum.
|
||||||
*/
|
*/
|
||||||
|
|
|
@ -56,7 +56,7 @@ class deactivated_super_global implements \ArrayAccess, \Countable, \IteratorAgg
|
||||||
$file = '';
|
$file = '';
|
||||||
$line = 0;
|
$line = 0;
|
||||||
|
|
||||||
$message = 'Illegal use of $' . $this->name . '. You must use the request class or request_var() to access input data. Found in %s on line %d. This error message was generated by deactivated_super_global.';
|
$message = 'Illegal use of $' . $this->name . '. You must use the request class to access input data. Found in %s on line %d. This error message was generated by deactivated_super_global.';
|
||||||
|
|
||||||
$backtrace = debug_backtrace();
|
$backtrace = debug_backtrace();
|
||||||
if (isset($backtrace[1]))
|
if (isset($backtrace[1]))
|
||||||
|
|
Loading…
Add table
Reference in a new issue