From 566b342b6732cfe33fe9ae578b6f5f318b8d2fc8 Mon Sep 17 00:00:00 2001 From: Graham Eames Date: Sat, 18 Feb 2006 15:28:45 +0000 Subject: [PATCH] Clearing up a query which is causing problems on large installs [Bug #723] git-svn-id: file:///svn/phpbb/branches/phpBB-2_0_0@5559 89ea8834-ac86-4346-8a33-228a782c2dd0 --- phpBB/admin/admin_groups.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/phpBB/admin/admin_groups.php b/phpBB/admin/admin_groups.php index 1074475afb..ad1cc33355 100644 --- a/phpBB/admin/admin_groups.php +++ b/phpBB/admin/admin_groups.php @@ -106,21 +106,19 @@ if ( isset($HTTP_POST_VARS['edit']) || isset($HTTP_POST_VARS['new']) ) // $sql = "SELECT user_id, username FROM " . USERS_TABLE . " - WHERE user_id <> " . ANONYMOUS . " - ORDER BY username"; + WHERE user_id = " . $group_info['group_moderator']; if ( !($result = $db->sql_query($sql)) ) { message_die(GENERAL_ERROR, 'Could not obtain user info for moderator list', '', __LINE__, __FILE__, $sql); } - while ( $row = $db->sql_fetchrow($result) ) + if ( !($row = $db->sql_fetchrow($result)) ) { - if ( $row['user_id'] == $group_info['group_moderator'] ) - { - $group_moderator = $row['username']; - } + message_die(GENERAL_ERROR, 'Could not obtain user info for moderator list', '', __LINE__, __FILE__, $sql); } + $group_moderator = $row['username']; + $group_open = ( $group_info['group_type'] == GROUP_OPEN ) ? ' checked="checked"' : ''; $group_closed = ( $group_info['group_type'] == GROUP_CLOSED ) ? ' checked="checked"' : ''; $group_hidden = ( $group_info['group_type'] == GROUP_HIDDEN ) ? ' checked="checked"' : '';