From 589ad564cc194bdca9cdada333ec60b2fa6a214b Mon Sep 17 00:00:00 2001 From: n-aleha Date: Sun, 25 May 2014 22:00:37 +0300 Subject: [PATCH] [ticket/12583] Redirect only on non-empty $message PHPBB3-12583 --- phpBB/includes/mcp/mcp_warn.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/phpBB/includes/mcp/mcp_warn.php b/phpBB/includes/mcp/mcp_warn.php index 0ef9200beb..df55c44134 100644 --- a/phpBB/includes/mcp/mcp_warn.php +++ b/phpBB/includes/mcp/mcp_warn.php @@ -316,9 +316,13 @@ class mcp_warn { $message = $user->lang['FORM_INVALID']; } - $redirect = append_sid("{$phpbb_root_path}mcp.$phpEx", "i=notes&mode=user_notes&u=$user_id"); - meta_refresh(2, $redirect); - trigger_error($message . '

' . sprintf($user->lang['RETURN_PAGE'], '', '')); + + if (!empty($message)) + { + $redirect = append_sid("{$phpbb_root_path}mcp.$phpEx", "i=notes&mode=user_notes&u=$user_id"); + meta_refresh(2, $redirect); + trigger_error($message . '

' . sprintf($user->lang['RETURN_PAGE'], '', '')); + } } // OK, they didn't submit a warning so lets build the page for them to do so