From 5b84c51d8165f3b93499504e0471ce9524a82d22 Mon Sep 17 00:00:00 2001 From: 3D-I Date: Tue, 23 Mar 2021 02:41:04 +0100 Subject: [PATCH] [ticket/16735] Fix access array offset on value of type bool on login PHPBB3-16735 --- phpBB/phpbb/auth/provider/db.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/phpBB/phpbb/auth/provider/db.php b/phpBB/phpbb/auth/provider/db.php index adb6554e72..2b8cc0d93b 100644 --- a/phpBB/phpbb/auth/provider/db.php +++ b/phpBB/phpbb/auth/provider/db.php @@ -154,8 +154,10 @@ class db extends base $login_error_attempts = 'LOGIN_ERROR_ATTEMPTS'; - $show_captcha = ($row) ? ($this->config['max_login_attempts'] && $row['user_login_attempts'] >= $this->config['max_login_attempts']) || - ($this->config['ip_login_limit_max'] && $attempts >= $this->config['ip_login_limit_max']) : false; + $user_login_attempts = $row ? ($this->config['max_login_attempts'] && $row['user_login_attempts'] >= $this->config['max_login_attempts']) : false; + $ip_login_attempts = (bool) ($this->config['ip_login_limit_max'] && $attempts >= $this->config['ip_login_limit_max']); + + $show_captcha = $user_login_attempts || $ip_login_attempts; if ($show_captcha) {