mirror of
https://github.com/phpbb/phpbb.git
synced 2025-06-28 14:18:52 +00:00
[ticket/10321] Add descriptions to the unit tests
PHPBB3-10321
This commit is contained in:
parent
dc149a43e4
commit
5d66faafc1
1 changed files with 15 additions and 15 deletions
|
@ -15,35 +15,35 @@ class phpbb_session_append_sid_test extends phpbb_test_case
|
||||||
public function append_sid_data()
|
public function append_sid_data()
|
||||||
{
|
{
|
||||||
return array(
|
return array(
|
||||||
array('viewtopic.php?t=1&f=2', false, true, false, 'viewtopic.php?t=1&f=2'),
|
array('viewtopic.php?t=1&f=2', false, true, false, 'viewtopic.php?t=1&f=2', 'parameters in url-argument'),
|
||||||
array('viewtopic.php', 't=1&f=2', true, false, 'viewtopic.php?t=1&f=2'),
|
array('viewtopic.php', 't=1&f=2', true, false, 'viewtopic.php?t=1&f=2', 'parameters in params-argument using amp'),
|
||||||
array('viewtopic.php', 't=1&f=2', false, false, 'viewtopic.php?t=1&f=2'),
|
array('viewtopic.php', 't=1&f=2', false, false, 'viewtopic.php?t=1&f=2', 'parameters in params-argument using &'),
|
||||||
array('viewtopic.php', array('t' => 1, 'f' => 2), true, false, 'viewtopic.php?t=1&f=2'),
|
array('viewtopic.php', array('t' => 1, 'f' => 2), true, false, 'viewtopic.php?t=1&f=2', 'parameters in params-argument as array'),
|
||||||
|
|
||||||
// Custom sid parameter
|
// Custom sid parameter
|
||||||
array('viewtopic.php', 't=1&f=2', true, 'custom-sid', 'viewtopic.php?t=1&f=2&sid=custom-sid'),
|
array('viewtopic.php', 't=1&f=2', true, 'custom-sid', 'viewtopic.php?t=1&f=2&sid=custom-sid', 'using session_id'),
|
||||||
|
|
||||||
// Testing anchors
|
// Testing anchors
|
||||||
array('viewtopic.php?t=1&f=2#anchor', false, true, false, 'viewtopic.php?t=1&f=2#anchor'),
|
array('viewtopic.php?t=1&f=2#anchor', false, true, false, 'viewtopic.php?t=1&f=2#anchor', 'anchor in url-argument'),
|
||||||
array('viewtopic.php', 't=1&f=2#anchor', true, false, 'viewtopic.php?t=1&f=2#anchor'),
|
array('viewtopic.php', 't=1&f=2#anchor', true, false, 'viewtopic.php?t=1&f=2#anchor', 'anchor in params-argument'),
|
||||||
array('viewtopic.php', array('t' => 1, 'f' => 2, '#' => 'anchor'), true, false, 'viewtopic.php?t=1&f=2#anchor'),
|
array('viewtopic.php', array('t' => 1, 'f' => 2, '#' => 'anchor'), true, false, 'viewtopic.php?t=1&f=2#anchor', 'anchor in params-argument (array)'),
|
||||||
|
|
||||||
// Anchors and custom sid
|
// Anchors and custom sid
|
||||||
array('viewtopic.php?t=1&f=2#anchor', false, true, 'custom-sid', 'viewtopic.php?t=1&f=2&sid=custom-sid#anchor'),
|
array('viewtopic.php?t=1&f=2#anchor', false, true, 'custom-sid', 'viewtopic.php?t=1&f=2&sid=custom-sid#anchor', 'anchor in url-argument using session_id'),
|
||||||
array('viewtopic.php', 't=1&f=2#anchor', true, 'custom-sid', 'viewtopic.php?t=1&f=2&sid=custom-sid#anchor'),
|
array('viewtopic.php', 't=1&f=2#anchor', true, 'custom-sid', 'viewtopic.php?t=1&f=2&sid=custom-sid#anchor', 'anchor in params-argument using session_id'),
|
||||||
array('viewtopic.php', array('t' => 1, 'f' => 2, '#' => 'anchor'), true, 'custom-sid', 'viewtopic.php?t=1&f=2&sid=custom-sid#anchor'),
|
array('viewtopic.php', array('t' => 1, 'f' => 2, '#' => 'anchor'), true, 'custom-sid', 'viewtopic.php?t=1&f=2&sid=custom-sid#anchor', 'anchor in params-argument (array) using session_id'),
|
||||||
|
|
||||||
// Empty parameters should not append the ?
|
// Empty parameters should not append the ?
|
||||||
array('viewtopic.php', false, true, false, 'viewtopic.php'),
|
array('viewtopic.php', false, true, false, 'viewtopic.php', 'no params using bool false'),
|
||||||
array('viewtopic.php', '', true, false, 'viewtopic.php'),
|
array('viewtopic.php', '', true, false, 'viewtopic.php', 'no params using empty string'),
|
||||||
array('viewtopic.php', array(), true, false, 'viewtopic.php'),
|
array('viewtopic.php', array(), true, false, 'viewtopic.php', 'no params using empty array'),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @dataProvider append_sid_data
|
* @dataProvider append_sid_data
|
||||||
*/
|
*/
|
||||||
public function test_append_sid($url, $params, $is_amp, $session_id, $expected)
|
public function test_append_sid($url, $params, $is_amp, $session_id, $expected, $description)
|
||||||
{
|
{
|
||||||
$this->assertEquals($expected, append_sid($url, $params, $is_amp, $session_id));
|
$this->assertEquals($expected, append_sid($url, $params, $is_amp, $session_id));
|
||||||
}
|
}
|
||||||
|
|
Loading…
Add table
Reference in a new issue