makary/phpbb
1
0
Fork 0
mirror of https://github.com/phpbb/phpbb.git synced 2025-06-28 14:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ticket/16394] Fix access array offset in MCP topic approval

Browse source 
PHPBB3-16394
This commit is contained in:
3D-I 2020-03-08 00:46:45 +01:00
parent ddc8e5c712
commit 5dac5fdb3b
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
phpBB/mcp.php
View file

@ -82,25 +82,25 @@ if ($post_id)
{ {
// We determine the topic and forum id here, to make sure the moderator really has moderative rights on this post // We determine the topic and forum id here, to make sure the moderator really has moderative rights on this post
$sql = 'SELECT topic_id, forum_id $sql = 'SELECT topic_id, forum_id
FROM ' . POSTS_TABLE . " FROM ' . POSTS_TABLE . '
WHERE post_id = $post_id"; WHERE post_id = ' . (int) $post_id;
$result = $db->sql_query($sql); $result = $db->sql_query($sql);
$row = $db->sql_fetchrow($result); $row = $db->sql_fetchrow($result);
$db->sql_freeresult($result); $db->sql_freeresult($result);
$topic_id = (int) $row['topic_id']; $topic_id = $row['topic_id'] ?? false;
$forum_id = (int) $row['forum_id']; $forum_id = $row['forum_id'] ?? false;
} }
else if ($topic_id) else if ($topic_id)
{ {
$sql = 'SELECT forum_id $sql = 'SELECT forum_id
FROM ' . TOPICS_TABLE . " FROM ' . TOPICS_TABLE . '
WHERE topic_id = $topic_id"; WHERE topic_id = ' . (int) $topic_id;
$result = $db->sql_query($sql); $result = $db->sql_query($sql);
$row = $db->sql_fetchrow($result); $row = $db->sql_fetchrow($result);
$db->sql_freeresult($result); $db->sql_freeresult($result);
$forum_id = (int) $row['forum_id']; $forum_id = $row['forum_id'] ?? false;
} }
// If the user doesn't have any moderator powers (globally or locally) he can't access the mcp // If the user doesn't have any moderator powers (globally or locally) he can't access the mcp