From 9b6149d3ac0549543a40283d67a0ac2a656c4fa8 Mon Sep 17 00:00:00 2001 From: brunoais Date: Mon, 23 Dec 2019 18:24:23 +0000 Subject: [PATCH 1/3] [ticket/16262] Add unset variables to fulltext_native compact PHPBB3-16262 --- phpBB/phpbb/search/fulltext_native.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/phpBB/phpbb/search/fulltext_native.php b/phpBB/phpbb/search/fulltext_native.php index 295c2cf33c..cb0c98baa6 100644 --- a/phpBB/phpbb/search/fulltext_native.php +++ b/phpBB/phpbb/search/fulltext_native.php @@ -782,6 +782,8 @@ class fulltext_native extends \phpbb\search\base $must_not_contain_ids = $this->must_not_contain_ids; $must_contain_ids = $this->must_contain_ids; + $sql_sort_table = $sql_sort_join = $sql_match = $sql_match_where = $sql_sort = ''; + /** * Allow changing the query used for counting for posts using fulltext_native * From faca59b3a6ded459bf67e66cf1088380e9850048 Mon Sep 17 00:00:00 2001 From: brunoais Date: Mon, 23 Dec 2019 18:25:36 +0000 Subject: [PATCH 2/3] [ticket/16262] Add unset variables to search's compact PHPBB3-16262 --- phpBB/search.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/phpBB/search.php b/phpBB/search.php index bd8025dae5..e50df13ea4 100644 --- a/phpBB/search.php +++ b/phpBB/search.php @@ -1214,6 +1214,10 @@ if ($keywords || $author || $author_id || $search_id || $submit) 'U_VIEW_POST' => (!empty($row['post_id'])) ? append_sid("{$phpbb_root_path}viewtopic.$phpEx", "f=$forum_id&t=" . $row['topic_id'] . '&p=' . $row['post_id'] . (($u_hilit) ? '&hilit=' . $u_hilit : '')) . '#p' . $row['post_id'] : '', )); + $folder_img = $folder_alt = $u_mcp_queue = ''; + $topic_type = $posts_unapproved = 0; + $unread_topic = $topic_unapproved = $topic_deleted = false; + /** * Modify the topic data before it is assigned to the template * From 202478d1088def6e73fd0a9abc0bf951b7b13132 Mon Sep 17 00:00:00 2001 From: brunoais Date: Thu, 26 Dec 2019 18:17:39 +0000 Subject: [PATCH 3/3] [ticket/16262] Fixing event's $current_row_number by renaming $i PHPBB3-16262 --- phpBB/includes/mcp/mcp_topic.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/phpBB/includes/mcp/mcp_topic.php b/phpBB/includes/mcp/mcp_topic.php index 83ad56f3e4..77db5f3ed0 100644 --- a/phpBB/includes/mcp/mcp_topic.php +++ b/phpBB/includes/mcp/mcp_topic.php @@ -242,7 +242,7 @@ function mcp_topic_view($id, $mode, $action) ); extract($phpbb_dispatcher->trigger_event('core.mcp_topic_modify_post_data', compact($vars))); - foreach ($rowset as $i => $row) + foreach ($rowset as $current_row_number => $row) { $message = $row['post_text']; $post_subject = ($row['post_subject'] != '') ? $row['post_subject'] : $topic_info['topic_title']; @@ -336,7 +336,7 @@ function mcp_topic_view($id, $mode, $action) } } - unset($rowset[$i]); + unset($rowset[$current_row_number]); } // Display topic icons for split topic