diff --git a/phpBB/includes/acp/acp_ranks.php b/phpBB/includes/acp/acp_ranks.php
index d9ed5b17f1..6b06d03f52 100644
--- a/phpBB/includes/acp/acp_ranks.php
+++ b/phpBB/includes/acp/acp_ranks.php
@@ -71,7 +71,7 @@ class acp_ranks
'rank_min' => $min_posts,
'rank_image' => htmlspecialchars_decode($rank_image)
);
-
+
if ($rank_id)
{
$sql = 'UPDATE ' . RANKS_TABLE . ' SET ' . $db->sql_build_array('UPDATE', $sql_ary) . " WHERE rank_id = $rank_id";
@@ -122,7 +122,7 @@ class acp_ranks
$cache->destroy('_ranks');
add_log('admin', 'LOG_RANK_REMOVED', $rank_title);
-
+
if ($request->is_ajax())
{
$json_response = new phpbb_json_response;
@@ -151,7 +151,7 @@ class acp_ranks
case 'add':
$data = $ranks = $existing_imgs = array();
-
+
$sql = 'SELECT *
FROM ' . RANKS_TABLE . '
ORDER BY rank_min ASC, rank_special ASC';
@@ -209,17 +209,17 @@ class acp_ranks
'RANK_TITLE' => (isset($ranks['rank_title'])) ? $ranks['rank_title'] : '',
'S_FILENAME_LIST' => $filename_list,
- 'RANK_IMAGE' => ($edit_img) ? $phpbb_root_path . $config['ranks_path'] . '/' . $edit_img : $phpbb_admin_path . 'images/spacer.gif',
+ 'RANK_IMAGE' => ($edit_img) ? $phpbb_root_path . $config['ranks_path'] . '/' . $edit_img : htmlspecialchars($phpbb_admin_path) . 'images/spacer.gif',
'S_SPECIAL_RANK' => (isset($ranks['rank_special']) && $ranks['rank_special']) ? true : false,
'MIN_POSTS' => (isset($ranks['rank_min']) && !$ranks['rank_special']) ? $ranks['rank_min'] : 0)
);
-
+
return;
break;
}
-
+
$template->assign_vars(array(
'U_ACTION' => $this->u_action)
);
@@ -241,7 +241,7 @@ class acp_ranks
'U_EDIT' => $this->u_action . '&action=edit&id=' . $row['rank_id'],
'U_DELETE' => $this->u_action . '&action=delete&id=' . $row['rank_id'])
- );
+ );
}
$db->sql_freeresult($result);
diff --git a/phpBB/includes/db/dbal.php b/phpBB/includes/db/dbal.php
index c2708b09b2..c6a3638f9f 100644
--- a/phpBB/includes/db/dbal.php
+++ b/phpBB/includes/db/dbal.php
@@ -852,7 +852,7 @@ class dbal
diff --git a/phpBB/includes/functions_acp.php b/phpBB/includes/functions_acp.php
index 2f3fd7bac0..32fd76e74d 100644
--- a/phpBB/includes/functions_acp.php
+++ b/phpBB/includes/functions_acp.php
@@ -82,16 +82,16 @@ function adm_page_header($page_title)
'T_RANKS_PATH' => "{$phpbb_root_path}{$config['ranks_path']}/",
'T_UPLOAD_PATH' => "{$phpbb_root_path}{$config['upload_path']}/",
- 'ICON_MOVE_UP' => '
![' . $user->lang['MOVE_UP'] . ' ' . $user->lang['MOVE_UP'] . '](' . $phpbb_admin_path . 'images/icon_up.gif)
',
- 'ICON_MOVE_UP_DISABLED' => '
![' . $user->lang['MOVE_UP'] . ' ' . $user->lang['MOVE_UP'] . '](' . $phpbb_admin_path . 'images/icon_up_disabled.gif)
',
- 'ICON_MOVE_DOWN' => '
![' . $user->lang['MOVE_DOWN'] . ' ' . $user->lang['MOVE_DOWN'] . '](' . $phpbb_admin_path . 'images/icon_down.gif)
',
- 'ICON_MOVE_DOWN_DISABLED' => '
![' . $user->lang['MOVE_DOWN'] . ' ' . $user->lang['MOVE_DOWN'] . '](' . $phpbb_admin_path . 'images/icon_down_disabled.gif)
',
- 'ICON_EDIT' => '
![' . $user->lang['EDIT'] . ' ' . $user->lang['EDIT'] . '](' . $phpbb_admin_path . 'images/icon_edit.gif)
',
- 'ICON_EDIT_DISABLED' => '
![' . $user->lang['EDIT'] . ' ' . $user->lang['EDIT'] . '](' . $phpbb_admin_path . 'images/icon_edit_disabled.gif)
',
- 'ICON_DELETE' => '
![' . $user->lang['DELETE'] . ' ' . $user->lang['DELETE'] . '](' . $phpbb_admin_path . 'images/icon_delete.gif)
',
- 'ICON_DELETE_DISABLED' => '
![' . $user->lang['DELETE'] . ' ' . $user->lang['DELETE'] . '](' . $phpbb_admin_path . 'images/icon_delete_disabled.gif)
',
- 'ICON_SYNC' => '
![' . $user->lang['RESYNC'] . ' ' . $user->lang['RESYNC'] . '](' . $phpbb_admin_path . 'images/icon_sync.gif)
',
- 'ICON_SYNC_DISABLED' => '
![' . $user->lang['RESYNC'] . ' ' . $user->lang['RESYNC'] . '](' . $phpbb_admin_path . 'images/icon_sync_disabled.gif)
',
+ 'ICON_MOVE_UP' => '
![' . $user->lang['MOVE_UP'] . ' ' . $user->lang['MOVE_UP'] . '](' . htmlspecialchars($phpbb_admin_path) . 'images/icon_up.gif)
',
+ 'ICON_MOVE_UP_DISABLED' => '
![' . $user->lang['MOVE_UP'] . ' ' . $user->lang['MOVE_UP'] . '](' . htmlspecialchars($phpbb_admin_path) . 'images/icon_up_disabled.gif)
',
+ 'ICON_MOVE_DOWN' => '
![' . $user->lang['MOVE_DOWN'] . ' ' . $user->lang['MOVE_DOWN'] . '](' . htmlspecialchars($phpbb_admin_path) . 'images/icon_down.gif)
',
+ 'ICON_MOVE_DOWN_DISABLED' => '
![' . $user->lang['MOVE_DOWN'] . ' ' . $user->lang['MOVE_DOWN'] . '](' . htmlspecialchars($phpbb_admin_path) . 'images/icon_down_disabled.gif)
',
+ 'ICON_EDIT' => '
![' . $user->lang['EDIT'] . ' ' . $user->lang['EDIT'] . '](' . htmlspecialchars($phpbb_admin_path) . 'images/icon_edit.gif)
',
+ 'ICON_EDIT_DISABLED' => '
![' . $user->lang['EDIT'] . ' ' . $user->lang['EDIT'] . '](' . htmlspecialchars($phpbb_admin_path) . 'images/icon_edit_disabled.gif)
',
+ 'ICON_DELETE' => '
![' . $user->lang['DELETE'] . ' ' . $user->lang['DELETE'] . '](' . htmlspecialchars($phpbb_admin_path) . 'images/icon_delete.gif)
',
+ 'ICON_DELETE_DISABLED' => '
![' . $user->lang['DELETE'] . ' ' . $user->lang['DELETE'] . '](' . htmlspecialchars($phpbb_admin_path) . 'images/icon_delete_disabled.gif)
',
+ 'ICON_SYNC' => '
![' . $user->lang['RESYNC'] . ' ' . $user->lang['RESYNC'] . '](' . htmlspecialchars($phpbb_admin_path) . 'images/icon_sync.gif)
',
+ 'ICON_SYNC_DISABLED' => '
![' . $user->lang['RESYNC'] . ' ' . $user->lang['RESYNC'] . '](' . htmlspecialchars($phpbb_admin_path) . 'images/icon_sync_disabled.gif)
',
'S_USER_LANG' => $user->lang['USER_LANG'],
'S_CONTENT_DIRECTION' => $user->lang['DIRECTION'],
diff --git a/phpBB/install/database_update.php b/phpBB/install/database_update.php
index 1600b7bd10..7795f8d7f7 100644
--- a/phpBB/install/database_update.php
+++ b/phpBB/install/database_update.php
@@ -236,7 +236,7 @@ if ($has_global && !$ga_forum_id)
-
+
@@ -286,7 +286,7 @@ header('Content-type: text/html; charset=UTF-8');
-
+
diff --git a/phpBB/install/index.php b/phpBB/install/index.php
index 69e9e7de42..643695ee2b 100644
--- a/phpBB/install/index.php
+++ b/phpBB/install/index.php
@@ -374,7 +374,7 @@ class module
'L_SELECT_LANG' => $lang['SELECT_LANG'],
'L_SKIP' => $lang['SKIP'],
'PAGE_TITLE' => $this->get_page_title(),
- 'T_IMAGE_PATH' => $phpbb_admin_path . 'images/',
+ 'T_IMAGE_PATH' => htmlspecialchars($phpbb_admin_path) . 'images/',
'S_CONTENT_DIRECTION' => $lang['DIRECTION'],
'S_CONTENT_FLOW_BEGIN' => ($lang['DIRECTION'] == 'ltr') ? 'left' : 'right',
@@ -577,7 +577,7 @@ class module
echo '';
echo '
';
echo '
' . $lang['INST_ERR_FATAL'] . '';
- echo '
';
+ echo '
';
echo '';
echo '';
echo '
';